Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add YAML formatting (prettier) #398

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Conversation

jrbourbeau
Copy link
Collaborator

Closes #364. I broke this into two commits, one which adds the pre-commit hook, and one which applies the formatting, to hopefully make reviewing a little easier.

cc @mfisher87 @betolink @jhkennedy

Copy link

github-actions bot commented Dec 5, 2023

Binder 👈 Launch a binder notebook on this branch for commit 111ed7f

I will automatically update this comment whenever this PR is modified

@MattF-NSIDC
Copy link

MattF-NSIDC commented Dec 5, 2023

I broke this into two commits, one which adds the pre-commit hook, and one which applies the formatting, to hopefully make reviewing a little easier.

💯 I love this approach, because it means later we can use .git-blame-ignore-revs to exclude massive formatting changes from blame view.

EDIT: https://github.blog/changelog/2022-03-24-ignore-commits-in-the-blame-view-beta/

@MattF-NSIDC MattF-NSIDC changed the title Add YAML linting Add YAML formatting (prettier) Dec 5, 2023
@MattF-NSIDC
Copy link

Beautiful 🤌

@jrbourbeau jrbourbeau merged commit 7ea45d8 into nsidc:main Dec 5, 2023
7 checks passed
@jrbourbeau jrbourbeau deleted the add-yaml-linting branch December 5, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint / format YAML
2 participants