-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch GitHub Pages deployment method/source to GitHub Actions #325
Conversation
deploy-documentation: | ||
if: | | ||
github.event_name == 'push' | ||
&& (github.ref == 'refs/heads/main' || github.ref == 'ref/heads/documentation') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where's the documentation
branch coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, honestly. It was based on stuff that was already here. @betolink ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah, originally I was thinking about having that branch to test changes to the docs without having to deploy main.
&& github.repository == 'nsidc/earthaccess' | ||
uses: peaceiris/actions-gh-pages@v3 | ||
- name: Upload site artifact | ||
uses: actions/upload-pages-artifact@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's a v2
release for this action (and the deploy-pages@
one too). Any reason to use v1
over v2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, was just lack of awareness and copy/pasting :)
Co-authored-by: James Bourbeau <[email protected]>
We are going to remove GitHub Actions workflow for the GitHub Pages automatic deployment and replace it with a static |
closes #323 , related to #277, will probably conflict with #324 :)
I really don't like dealing with an extra branch in my source repo for something that is not source. What do you all think?
This requires a change in the Pages admin panel: