Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch GitHub Pages deployment method/source to GitHub Actions #325

Closed
wants to merge 2 commits into from

Conversation

mfisher87
Copy link
Collaborator

@mfisher87 mfisher87 commented Oct 21, 2023

closes #323 , related to #277, will probably conflict with #324 :)

I really don't like dealing with an extra branch in my source repo for something that is not source. What do you all think?

This requires a change in the Pages admin panel:

image

@github-actions
Copy link

github-actions bot commented Oct 21, 2023

Binder 👈 Launch a binder notebook on this branch for commit fdddf37

I will automatically update this comment whenever this PR is modified

Binder 👈 Launch a binder notebook on this branch for commit d7b65c5

@mfisher87 mfisher87 changed the title Switch GitHub Deployment method to Actions Switch GitHub Pages deployment method/surce to GitHub Actions Oct 21, 2023
@mfisher87 mfisher87 changed the title Switch GitHub Pages deployment method/surce to GitHub Actions Switch GitHub Pages deployment method/source to GitHub Actions Oct 21, 2023
.github/workflows/documentation.yml Outdated Show resolved Hide resolved
deploy-documentation:
if: |
github.event_name == 'push'
&& (github.ref == 'refs/heads/main' || github.ref == 'ref/heads/documentation')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the documentation branch coming from?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, honestly. It was based on stuff that was already here. @betolink ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah, originally I was thinking about having that branch to test changes to the docs without having to deploy main.

&& github.repository == 'nsidc/earthaccess'
uses: peaceiris/actions-gh-pages@v3
- name: Upload site artifact
uses: actions/upload-pages-artifact@v1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a v2 release for this action (and the deploy-pages@ one too). Any reason to use v1 over v2?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, was just lack of awareness and copy/pasting :)

Co-authored-by: James Bourbeau <[email protected]>
@mfisher87
Copy link
Collaborator Author

mfisher87 commented Nov 22, 2023

We are going to remove GitHub Actions workflow for the GitHub Pages automatic deployment and replace it with a static index.html file that redirects to RTD. See: #277

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch GitHub pages from "branch" source to "actions"/API source
4 participants