Skip to content

Commit

Permalink
Decouple test, lint, typecheck scripts
Browse files Browse the repository at this point in the history
Maybe we could use Nox instead of scripts at some point? Then the
behaviors can be coupled to the correct environments.
  • Loading branch information
mfisher87 committed Jun 30, 2024
1 parent 1b84b1f commit dbfa08e
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ jobs:
# When using `act` to run the workflow locally, the `poetry install` command
# may fail due to network issues when running multiple Docker containers.
run: poetry install -E test || poetry install -E test || poetry install -E test
- name: Typecheck
run: poetry run bash scripts/typecheck.sh
- name: Test
run: poetry run bash scripts/test.sh
- name: Upload coverage
Expand Down
1 change: 0 additions & 1 deletion scripts/lint.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,4 @@

set -ex

mypy earthaccess stubs tests
ruff check .
1 change: 0 additions & 1 deletion scripts/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,3 @@ set -e
set -x

pytest tests/unit --cov=earthaccess --cov=tests --cov-report=term-missing "${@}" -s --tb=native --log-cli-level=INFO
bash ./scripts/lint.sh
5 changes: 5 additions & 0 deletions scripts/typecheck.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
#!/usr/bin/env bash

set -ex

mypy earthaccess stubs tests

0 comments on commit dbfa08e

Please sign in to comment.