Merge pull request #516 from itcarroll/obdaac

add obdaac s3-credential endpoint
nsidc · Apr 12, 2024 · 8d65d03 · 8d65d03
2 parents 493dd03 + 8dc3a1f
commit 8d65d03
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 7 deletions.
diff --git a/earthaccess/daac.py b/earthaccess/daac.py
@@ -70,10 +70,10 @@
     {
         "short-name": "OBDAAC",
         "name": "NASA's Ocean Biology Distributed Active Archive Center",
-        "homepage": "https://earthdata.nasa.gov/eosdis/daacs/obdaac",
-        "cloud-providers": [],
+        "homepage": "https://oceancolor.gsfc.nasa.gov/",
+        "cloud-providers": ["OB_CLOUD"],
         "on-prem-providers": ["OB_DAAC"],
-        "s3-credentials": "",
+        "s3-credentials": "https://obdaac-tea.earthdatacloud.nasa.gov/s3credentials",
         "eulas": [],
     },
     {

diff --git a/tests/unit/test_collection_queries.py b/tests/unit/test_collection_queries.py
@@ -27,9 +27,9 @@ def test_query_can_find_cloud_provider():
     assert query.params["provider"] == "POCLOUD"
     query = DataCollections().cloud_hosted(True).daac("PODAAC")
     assert query.params["provider"] == "POCLOUD"
-    # OBDAAC does not have a cloud provider so it should default to the on prem provider
-    query = DataCollections().cloud_hosted(True).daac("OBDAAC")
-    assert query.params["provider"] == "OB_DAAC"
+    # SEDAC does not have a cloud provider so it should default to the on prem provider
+    query = DataCollections().cloud_hosted(True).daac("SEDAC")
+    assert query.params["provider"] == "SEDAC"
 
 
 def test_querybuilder_can_handle_doi():

diff --git a/tests/unit/test_store.py b/tests/unit/test_store.py
@@ -97,7 +97,15 @@ def test_store_can_create_s3_fsspec_session(self):
 
         store = Store(self.auth)
         self.assertTrue(isinstance(store.auth, Auth))
-        for daac in ["NSIDC", "PODAAC", "LPDAAC", "ORNLDAAC", "GES_DISC", "ASF"]:
+        for daac in [
+            "NSIDC",
+            "PODAAC",
+            "LPDAAC",
+            "ORNLDAAC",
+            "GES_DISC",
+            "ASF",
+            "OBDAAC",
+        ]:
             s3_fs = store.get_s3fs_session(daac=daac)
             assert isinstance(s3_fs, s3fs.S3FileSystem)
             assert s3_fs.storage_options == expected_storage_options
@@ -114,6 +122,7 @@ def test_store_can_create_s3_fsspec_session(self):
             "ORNL_CLOUD",
             "GES_DISC",
             "ASF",
+            "OB_CLOUD",
         ]:
             s3_fs = store.get_s3fs_session(provider=provider)
             assert isinstance(s3_fs, s3fs.S3FileSystem)