Task/cu 86942hp4v/7 shop create retail plugin for gg

[thedev966]

References:
https://app.clickup.com/t/86942hp4v

[nsoft-bot]

Task linked: CU-86942hp4v 7Shop - Create Retail plugin for GG

[sonarqubepr-nsoft]

• 0.00% Coverage on New Code (is less than 80.00%)

Analysis Details

6 Issues

• 0 Bugs
• 0 Vulnerabilities
• 6 Code Smells

Coverage and Duplications

• 0.00% Coverage (0.00% Estimated after merge)
• 0.00% Duplicated Code (10.90% Estimated after merge)

Project ID: seven-gravity-gateway

View in SonarQube

[dev387]

Also try to fix SonarQube errors: Unexpected var, use let or const instead.

[Lanchi]

Does this means that slave would now have to initialize GG like:

import Gateway from '@nsoft/seven-gravity-gateway/slave';
import BarcodeScanPlugin from '@nsoft/seven-gravity-gateway/plugin-barcode-scan';
import RetailPlugin from '@nsoft/seven-gravity-gateway/retail';

Gateway({
    ...
    plugins: [new BarcodeScanPlugin(), new RetailPlugin()]
    ...
});

@dikaso we mentioned that it would be nice to 'bundle up' necessary plugins for retail app to Retail plugin (i.e. other plugins like barcode would be implicitly initialized from Retail plugin). Could this be done in this PR so slave would in the end only need to do

Gateway({
    ...
    plugins: [new RetailPlugin()]
    ...
});

Also, @thedev966 please add appropriate documentation regarding this new plugin.

[thedev966]

Does this means that slave would now have to initialize GG like:

import Gateway from '@nsoft/seven-gravity-gateway/slave';
import BarcodeScanPlugin from '@nsoft/seven-gravity-gateway/plugin-barcode-scan';
import RetailPlugin from '@nsoft/seven-gravity-gateway/retail';

Gateway({
    ...
    plugins: [new BarcodeScanPlugin(), new RetailPlugin()]
    ...
});

@dikaso we mentioned that it would be nice to 'bundle up' necessary plugins for retail app to Retail plugin (i.e. other plugins like barcode would be implicitly initialized from Retail plugin). Could this be done in this PR so slave would in the end only need to do

Gateway({
    ...
    plugins: [new RetailPlugin()]
    ...
});

Also, @thedev966 please add appropriate documentation regarding this new plugin.

We'll bundle up plugins in the next task. Updated wiki to include section for Retail plugin.

[dikaso]

If preventKeys is not sent for some reason this will throw error. @thedev966

[thedev966]

@dikaso It's possible case? Okay, I'll add some check in this next task I'm on.

[dikaso]

I think so. It is not required to set preventKeys for a tenant.

[thedev966]

But, we will always set preventKeys, by default empty array, and override settings per tenant when needed. forEach shouldn't throw any error..