Big refactor #166
Big refactor #166
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
A few small fixes required, otherwise good
Summary:
This PR refactors the codebase by removing 'modes', replacing AuthError with Error, moving some components to a shared directory, and converting function definitions to arrow function syntax.
Key points:
- Removed the concept of 'modes' from the single page web app
- Deleted
AuthErrorand replaced it withErrorcomponent - Moved some components to
src/components/shared/ - Converted function definitions to arrow function syntax
- Changes spread across multiple files including
SignInForm.tsx,SignUpForm.tsx,Home.tsx,ResponsesTable.tsx,Error.tsx, andhome.tsx
Generated with ❤️ by ellipsis.dev
| <form | ||
| className="space-y-6" | ||
| action="#" | ||
| method="POST" | ||
| onSubmit={onFormSubmit} | ||
| onSubmit={() => onFormSubmit} |
There was a problem hiding this comment.
The onFormSubmit function is not being called correctly. It should be passed as a reference, not invoked. Change onSubmit={() => onFormSubmit} to onSubmit={onFormSubmit}.
There was a problem hiding this comment.
@ellipsis-dev fix it
There was a problem hiding this comment.
@ellipsis-dev fix it
There was a problem hiding this comment.
@ellipsis-dev fix it
| @@ -40,7 +40,7 @@ export default function SignInForm() { | |||
|
|
|||
| return ( | |||
| <> | |||
| {error && <ErrorAlert error={error} />} | |||
| {error && <Error error={error} session={null}/>} | |||
There was a problem hiding this comment.
The Error component is being used with a session prop set to null. This might cause issues if the Error component expects a valid session. Please ensure that the Error component can handle a null session.
AuthErrorand using theErrorcomponent everywheresrc/components/shared/functionto using arrow function syntax