Change color of ServiceAlert global-deviation variant #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 13, 2025 13:37
matsfolles
requested review from
Cmoen11,
leiferikbjorkli,
marcogravbrot,
cibietici,
alicemacl,
MTeresita and
mcklien
and removed request for
a team
🦋 Changeset detectedLatest commit: 793e13f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alicemacl
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
There was a need to make the two variants of the ServiceAlert component have identical colors, so that the color does not suddenly change when changing view for cases where the views have different ServiceAlert variants
Solution
Change the colors of the "global-deviation" to be equal the "service" variant
If no packages, only docs has been changed:
How to test
Start the application manually, then check the last variant of the component showcased under: http://localhost:3000/components/alert
Screenshots