Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move aria-label to improve ChoiceChip voiceover #1454

Closed
wants to merge 1 commit into from

Conversation

ailhay
Copy link
Contributor

@ailhay ailhay commented Jan 8, 2025

Background

The voiceover on the checkbox is weird. When moving using voiceover buttons (on mac) you need to click three times to move out of a checkbox.

Solution

Move aria-label for check box from label to input.

UU checks

  • It is possible to use the keyboard to reach your changes
  • It is possible to enlarge the text 400% without losing functionality
  • It works on both mobile and desktop
  • It works in both Chrome, Safari and Firefox
  • It works with VoiceOver
  • There are no errors in aXe / SiteImprove-plugins / Wave
  • Sanity documentation has been / will be updated (if neccessary)

If no packages, only docs has been changed:

  • Documentation version has been bumped (package.json in docs)

Everything about making a React component:
https://spor.vy.no/guides/how-to-make-new-react-components

HOW TO MAKE A CHANGESET:
Go here: https://spor.vy.no/guides/how-to-make-new-react-components#creating-a-pr-and-publish-package

How to test

Run spor locally and go to the playground. Add different check boxes and test out voiceover on them.

Copy link

changeset-bot bot commented Jan 8, 2025

⚠️ No Changeset found

Latest commit: 0fe40b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ailhay
Copy link
Contributor Author

ailhay commented Jan 8, 2025

Fikk beskjed at choice chip var bra nok under testing.

@ailhay ailhay closed this Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant