Move aria-label to improve ChoiceChip voiceover #1454
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The voiceover on the checkbox is weird. When moving using voiceover buttons (on mac) you need to click three times to move out of a checkbox.
Solution
Move aria-label for check box from label to input.
UU checks
If no packages, only docs has been changed:
Everything about making a React component:
https://spor.vy.no/guides/how-to-make-new-react-components
HOW TO MAKE A CHANGESET:
Go here: https://spor.vy.no/guides/how-to-make-new-react-components#creating-a-pr-and-publish-package
How to test
Run spor locally and go to the playground. Add different check boxes and test out voiceover on them.