Skip to content
This repository has been archived by the owner on Mar 22, 2021. It is now read-only.

Make Rails 5.2.1 compatible #225

Closed
wants to merge 1 commit into from

Conversation

kaliaabhishek
Copy link

No description provided.

Copy link

@ariataylor96 ariataylor96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@stevenmichaelthomas
Copy link

You should try to update https://github.com/nsarno/knock/blob/66b60437a5acc28e4863f011ab59324dc1b5d0ae/lib/generators/templates/knock.rb

To make sure the proper default is referenced.

@stevenmichaelthomas
Copy link

Also, will this break for versions prior to Rails 5.2? If so, it may be good to add in a flag here to check rails version, or check for the existence of Rails.application.credentials

@andrerpbts
Copy link
Collaborator

andrerpbts commented Mar 17, 2020

Hello @kaliaabhishek

Are you still open to change this code? I'm asking because it could be useful if we improve a bit this part. Like was stated here #212, I think we could have an error code for when the credentials aren't provided to Knock, and identify the Rails version to select the default way. Of course, we should keep it simple to the people installing the gem in their projects to change it easily...

WDYT @nsarno?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants