-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nextjs): produce correct next.config.js file for production server #15824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
jaysoo
force-pushed
the
fix/nextjs-remove-inlined-with-nx
branch
from
March 22, 2023 15:00
ba98e5d
to
658311f
Compare
packages/next/src/executors/build/lib/create-next-config-file.ts
Outdated
Show resolved
Hide resolved
jaysoo
force-pushed
the
fix/nextjs-remove-inlined-with-nx
branch
6 times, most recently
from
March 22, 2023 16:38
021614d
to
51d972f
Compare
jaysoo
force-pushed
the
fix/nextjs-remove-inlined-with-nx
branch
from
March 22, 2023 17:34
51d972f
to
cdd3192
Compare
ndcunningham
approved these changes
Mar 22, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the generated
next.config.js
file errors out due towith-nx.js
referencing relative paths that do no exist.For reference, the reason we previously used a compiled version of
with-nx.js
rather than@nrwl/next/plugins/with-nx
is because@nrwl/next
installs development packages (e.g. Cypress, Webpack, etc.) that bloated the built artifact. See: #12150This fix has two components:
@nrwl/cypress
,@nrwl/jest
, and@nrwl/webpack
. frompackages/next/package.json
intoensurePackage
whenever they are used by generators. This change addresses the package size issue.with-nx.js
and use the normal plugin again. This requires a check on the "phase" so that webpack and eslint configurations are only added when doing builds. By checking the phase, we no longer need access to Nx graph since everything has already been compiled into.next.
.Current Behavior
Production build cannot run
Expected Behavior
Production build can run
Related Issue(s)
Fixes #15796