Fix: segment not found issues (SOFIE-3626)

[nytamin]

About the Contributor

This pull request is posted on behalf of the NRK

Type of Contribution

This is a:

Bug fix

Current Behavior

We have experienced various issues in production related to error messages of the Segment "xyz" not found type.
While we haven't confidently identified the core issue we have found a few potential problems introduced in release51.

Fixes

• If the NRCS removes a Part that is currently the previous Part in Sofie, the syncChangesToPartInstances failed because the Segment of the previous PartInstance was not found.
  The fix: Include previous PartInstance in the orphan-Segment-check, so that the Segment will now be orphaned instead of removed.
• If the NRCS removes the first Part in a Segment, this changes the id of the Segment (this is normal). There was a potential situation in the updatePartInstancesSegmentIds method where the new ids are to be synced to the PartInstances, that has now been fixed.

Testing

• I have added one or more unit tests for this PR
• I have updated the relevant unit tests
• No unit test changes are needed for this PR

Affected areas

• This PR affects ingest operations
• This PR affects takes/Next/Adlibbing/playout logic in general

Time Frame

This Bug Fix is critical for us, we till merge this asap.

Other Information

Status

• PR is ready to be reviewed.
• The functionality has been tested by the author.
• Relevant unit tests has been added / updated.
• Relevant documentation (code comments, system documentation) has been added / updated.

[codecov]

Codecov Report

Attention: Patch coverage is 79.70297% with 41 lines in your changes missing coverage. Please review.

Project coverage is 58.02%. Comparing base (d908ac6) to head (93f4b9d).

Files with missing lines	Patch %	Lines
...c/playout/model/implementation/PlayoutModelImpl.ts	0.00%	23 Missing ⚠️
...ckages/job-worker/src/playout/timeline/generate.ts	0.00%	12 Missing ⚠️
packages/job-worker/src/playout/infinites.ts	76.19%	5 Missing ⚠️
packages/job-worker/src/ingest/commit.ts	99.01%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##           release51    #1325      +/-   ##
=============================================
+ Coverage      57.96%   58.02%   +0.05%     
=============================================
  Files            525      525              
  Lines          84951    85094     +143     
  Branches        4443     4437       -6     
=============================================
+ Hits           49245    49376     +131     
+ Misses         35673    35664       -9     
- Partials          33       54      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles