Changes needed for SDP MSPI #2260
Open
+90
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaz1-nordic
force-pushed
the
nrfx-6633_sdp_mspi
branch
from
4e5d7cd to
6303428
Compare
jaz1-nordic
force-pushed
the
nrfx-6633_sdp_mspi
branch
from
6303428 to
5e9326e
Compare
nordic-piks
reviewed
Nov 18, 2024
nordic-piks
reviewed
Nov 18, 2024
masz-nordic
reviewed
Nov 20, 2024
Comment on lines
16
to
23
| sdp_mspi: sdp_mspi@5004c000 { | ||
| mspi_device: mspi_device@0 { | ||
| status = "okay"; | ||
| compatible = "zephyr,mspi-emul-device"; | ||
| reg = <0x0>; | ||
| mspi-max-frequency = <48000000>; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
As mentioned offline, this redefinition is needed because those lines:
https://github.com/nrfconnect/sdk-nrf/pull/18893/files#diff-46fdf8d2608e604b87bd6b25d0cb3243ecc117f0d63f536def7c8e8532a09c41R87-R94
are applied only after this file.
I will look into how this could be solved, until now it would be nice to add a comment here about the issue.
There was a problem hiding this comment.
I've modified the driver a bit so that it's not necessary to use the address. Unfortunately, the order is still important.
Comment on lines
+373
to
+375
| dir = NRF_GPIO_PIN_DIR_OUTPUT; | ||
| input = NRF_GPIO_PIN_INPUT_CONNECT; |
There was a problem hiding this comment.
Are there any expectations in VIO regarding pre-configuration by GPIO peripheral?
I'm wondering about the nrf_gpio_pin_write and nrf_gpio_cfg below.
jaz1-nordic
force-pushed
the
nrfx-6633_sdp_mspi
branch
2 times, most recently
from
89ff635 to
d0b40cf
Compare
jaz1-nordic
changed the title
jaz1-nordic
force-pushed
the
nrfx-6633_sdp_mspi
branch
2 times, most recently
from
73a3080 to
dc94f79
Compare
jaz1-nordic
changed the title
|
Other 2 commits need |
jaz1-nordic
force-pushed
the
nrfx-6633_sdp_mspi
branch
2 times, most recently
from
0dd7466 to
f345131
Compare
jaz1-nordic
force-pushed
the
nrfx-6633_sdp_mspi
branch
from
f345131 to
bc38304
Compare
jukkar
requested review from
carlescufi,
de-nordic,
nordic-krch and
a team
as code owners
jaz1-nordic
force-pushed
the
nrfx-6633_sdp_mspi
branch
from
bc38304 to
c77f084
Compare
Add ifdefs to make MSPI API test more generic. Upstream PR #: 81870 Signed-off-by: Jakub Zymelka <[email protected]>
Configure SDP MSPI pins to switch their control to VPR core Signed-off-by: Jakub Zymelka <[email protected]>
Add nRF54l15 overlay file to be able to run SDP MSPI API test. Signed-off-by: Jakub Zymelka <[email protected]>
jaz1-nordic
force-pushed
the
nrfx-6633_sdp_mspi
branch
from
c77f084 to
99fd4fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed to implement SDP MSPI version: