ci: Add a workflow to check Wi-Fi FW patch version #1117
Conversation
krish2718
force-pushed
the
ci_for_patch_version
branch
5 times, most recently
from
988aec2
to
f0c9bd4
Compare
| if: ${{ always() }} | ||
| uses: actions/github-script@v3 | ||
| with: | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
have you tested this?
I can't remember if checks in this context have the correct permissions to write comments
There was a problem hiding this comment.
Still under testing, it doesn't work properly, my act doesn't seem to work, so, I am using this PR as my tests :).
I can't remember if checks in this context have the correct permissions to write comments
Oh, currently the step fails with an exception, I will check once its fixed.
There was a problem hiding this comment.
Error: Unhandled error: HttpError: Resource not accessible by integration
Token doesn't have permissions, should I use a personal token or should we add commenting permissions? @thst-nordic
There was a problem hiding this comment.
or I have modified to use pull_request_target but that requires merging
There was a problem hiding this comment.
The GITHUB_TOKEN is an ephemeral token that will never have comment writing permissions.
to do this you need to have a static token from a bot that has comment permissions.
This is done in sdk-nrf with secrets.NCS_GITHUB_TOKEN
like this:
https://github.com/nrfconnect/sdk-nrf/blob/4efd7d8184a91ba8f87c797b740e31a00a0c4c83/.github/workflows/docpublish.yml#L69
static token is less safe than using GITHUB_TOKEN so you must be more careful that it can't be extracted on a public repo.
krish2718
force-pushed
the
ci_for_patch_version
branch
9 times, most recently
from
93280de
to
e621141
Compare
krish2718
requested review from
sachinthegreen,
udaynordic,
srkanordic and
rajb9
krish2718
force-pushed
the
ci_for_patch_version
branch
from
e621141
to
d1f1cfd
Compare
This workflow checks the version between the C header and the firmware patch bins and leaves a comment. Signed-off-by: Chaitanya Tata <[email protected]>
krish2718
force-pushed
the
ci_for_patch_version
branch
from
d1f1cfd
to
692e4d1
Compare
This workflow checks the version between the C header and the firmware patch bins and leaves a comment.