Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: nrf_modem: fixes for flash trace backend #18348

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

eivindj-nordic
Copy link
Contributor

@eivindj-nordic eivindj-nordic commented Oct 29, 2024

Fixes for trace flash backend.

This PR fixes an issue with the trace flash backend where there is a mismatch between the traces to read and the read trace data, such that the trace module will report that there is still trace data to read even though the backend is emptied.

@eivindj-nordic eivindj-nordic self-assigned this Oct 29, 2024
@eivindj-nordic eivindj-nordic requested review from a team as code owners October 29, 2024 14:46
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 29, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 29, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 9

Inputs:

Sources:

sdk-nrf: PR head: 187e02380222aca97c2db8df3413f2847fd7f648

more details

sdk-nrf:

PR head: 187e02380222aca97c2db8df3413f2847fd7f648
merge base: 53bebe9d9bc0430f643812334b1411a0e20a38ad
target head (main): e1f2c6b39e074f9af97ad472e7d0e37cec84ea2b
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
lib
│  ├── nrf_modem_lib
│  │  ├── nrf_modem_lib_trace.c
│  │  ├── trace_backends
│  │  │  ├── flash
│  │  │  │  │ flash.c

Outputs:

Toolchain

Version: add720b6d9
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:add720b6d9_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 405
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ⚠️ test-fw-nrfconnect-nrf-iot_serial_lte_modem
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi

Note: This message is automatically posted and updated by the CI

@eivindj-nordic eivindj-nordic added bug Something isn't working backport v2.8-branch auto-create a PR with same commits to v2.8-branch labels Oct 29, 2024
@eivindj-nordic
Copy link
Contributor Author

eivindj-nordic commented Oct 29, 2024

Removing requirement for changelog entry as it is covered by #17682.

@eivindj-nordic eivindj-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 29, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@eivindj-nordic eivindj-nordic added this to the 2.8.0 milestone Oct 30, 2024
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 30, 2024
@eivindj-nordic eivindj-nordic force-pushed the trace_flash_backend branch 2 times, most recently from 65eea12 to 5d0a5a8 Compare October 31, 2024 07:18
Fixes for trace flash backend.

Signed-off-by: Eivind Jølsgard <[email protected]>
Copy link
Contributor

@simensrostad simensrostad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@rlubos rlubos merged commit abb1738 into nrfconnect:main Oct 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v2.8-branch auto-create a PR with same commits to v2.8-branch bug Something isn't working changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants