subsys: net: download_client rework #17481
Open
+5,438
−410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 761cfb8d85fbd80059f100b174816fee76d2f4ff more detailssdk-nrf:
Github labels
List of changed files detected by CI (116)Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
SeppoTakalo
reviewed
Sep 26, 2024
include/net/download_client.h
Outdated
Comment on lines
133
to
137
| struct download_client_host_cfg { | ||
| /** Server hosting the file, null-terminated. | ||
| * The host name must be kept in scope while download is going on. | ||
| */ | ||
| const char *hostname; |
There was a problem hiding this comment.
Since you are so heavily refactoring, I would propose that we get rid of this separation of host and path.
Just use URI on the API.
It is actually very rare that any interfaces would give us host and path separately. I only know nRF Cloud to do so on some REST APIs. It is more common that we receive full URI where to fetch the data.
There was a problem hiding this comment.
Oh.. and also now host is provided inside a struct and path is provided as a function parameter. This emphasizes the separation even further.
It feels like cleanest API would just take URI as one parameter, or field inside this struct. Let the HTTP parser to split protocol, host, port and path.
eivindj-nordic
force-pushed
the
25700_download_client_rework
branch
from
3af4cbb
to
3e9412e
Compare
github-actions
bot
removed
the
changelog-entry-required
eivindj-nordic
force-pushed
the
25700_download_client_rework
branch
6 times, most recently
from
6573c1d
to
2666f2d
Compare
eivindj-nordic
force-pushed
the
25700_download_client_rework
branch
9 times, most recently
from
272b2de
to
c058985
Compare
eivindj-nordic
force-pushed
the
25700_download_client_rework
branch
from
c058985
to
49e7000
Compare
eivindj-nordic
added
CI-run-twister
and removed
CI-run-zephyr-twister
CI-run-twister
labels
|
Marking ready for review to trigger CI. |
divipillai
reviewed
Nov 21, 2024
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/migration/migration_guide_2.9.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/migration/migration_guide_2.9.rst
Outdated
Show resolved
Hide resolved
peknis
requested changes
Nov 21, 2024
Comment on lines
106
to
108
| .. code-block:: C | ||
| #include <net/download_client.h> |
There was a problem hiding this comment.
Suggested change
| .. code-block:: C | |
| #include <net/download_client.h> | |
| .. code-block:: C | |
| #include <net/download_client.h> |
Comment on lines
112
to
114
| .. code-block:: C | ||
| #include <net/downloader.h> |
There was a problem hiding this comment.
Suggested change
| .. code-block:: C | |
| #include <net/downloader.h> | |
| .. code-block:: C | |
| #include <net/downloader.h> |
Comment on lines
118
to
125
| * Remove: | ||
|
|
||
| .. code-block:: C | ||
| static struct download_client dlc; | ||
| static int callback(const struct download_client_evt *event); | ||
| download_client_init(&dlc, callback) |
There was a problem hiding this comment.
Suggested change
| * Remove: | |
| .. code-block:: C | |
| static struct download_client dlc; | |
| static int callback(const struct download_client_evt *event); | |
| download_client_init(&dlc, callback) | |
| * Remove: | |
| .. code-block:: C | |
| static struct download_client dlc; | |
| static int callback(const struct download_client_evt *event); | |
| download_client_init(&dlc, callback) |
Comment on lines
172
to
183
| * Remove: | ||
|
|
||
| .. code-block:: C | ||
| int err; | ||
| const struct download_client_cfg dlc_config = { | ||
| ... | ||
| }; | ||
| err = download_client_set_host(&dlc, dl_host, &dlc_config); | ||
| err = download_client_start(&dlc, dl_file, offset); |
There was a problem hiding this comment.
Suggested change
| * Remove: | |
| .. code-block:: C | |
| int err; | |
| const struct download_client_cfg dlc_config = { | |
| ... | |
| }; | |
| err = download_client_set_host(&dlc, dl_host, &dlc_config); | |
| err = download_client_start(&dlc, dl_file, offset); | |
| * Remove: | |
| .. code-block:: C | |
| int err; | |
| const struct download_client_cfg dlc_config = { | |
| ... | |
| }; | |
| err = download_client_set_host(&dlc, dl_host, &dlc_config); | |
| err = download_client_start(&dlc, dl_file, offset); |
Comment on lines
185
to
205
| * Add: | ||
|
|
||
| .. code-block:: C | ||
| /* Note: All configuration of the downloader is done through the config structs. | ||
| * The downloader struct should not be modified by the application. | ||
| */ | ||
| static struct downloader_host_cfg host_config = { | ||
| ... | ||
| /* Note: | ||
| * .frag_size_override is replaced by .range_override. | ||
| * .set_tls_hostname is replaced by .set_native_tls. | ||
| * dlc.close_when_done is moved here and inverted(.keep_connection). | ||
| * Set .cid if CONFIG_DOWNLOAD_CLIENT_CID was enabled in download client. | ||
| */ | ||
| }; | ||
| int err = downloader_get_with_host_and_path(&dl, &host_config, dl_host, dl_file, offset); | ||
| .. note:: The new downloader has an API to download the file using the URI directly. |
There was a problem hiding this comment.
Suggested change
| * Add: | |
| .. code-block:: C | |
| /* Note: All configuration of the downloader is done through the config structs. | |
| * The downloader struct should not be modified by the application. | |
| */ | |
| static struct downloader_host_cfg host_config = { | |
| ... | |
| /* Note: | |
| * .frag_size_override is replaced by .range_override. | |
| * .set_tls_hostname is replaced by .set_native_tls. | |
| * dlc.close_when_done is moved here and inverted(.keep_connection). | |
| * Set .cid if CONFIG_DOWNLOAD_CLIENT_CID was enabled in download client. | |
| */ | |
| }; | |
| int err = downloader_get_with_host_and_path(&dl, &host_config, dl_host, dl_file, offset); | |
| .. note:: The new downloader has an API to download the file using the URI directly. | |
| * Add: | |
| .. code-block:: C | |
| /* Note: All configuration of the downloader is done through the config structs. | |
| * The downloader struct should not be modified by the application. | |
| */ | |
| static struct downloader_host_cfg host_config = { | |
| ... | |
| /* Note: | |
| * .frag_size_override is replaced by .range_override. | |
| * .set_tls_hostname is replaced by .set_native_tls. | |
| * dlc.close_when_done is moved here and inverted(.keep_connection). | |
| * Set .cid if CONFIG_DOWNLOAD_CLIENT_CID was enabled in download client. | |
| */ | |
| }; | |
| int err = downloader_get_with_host_and_path(&dl, &host_config, dl_host, dl_file, offset); | |
| .. note:: | |
| The new downloader has an API to download the file using the URI directly. |
Comment on lines
212
to
216
| * Add: | ||
|
|
||
| .. code-block:: C | ||
| err = downloader_deinit(&dl); |
There was a problem hiding this comment.
Suggested change
| * Add: | |
| .. code-block:: C | |
| err = downloader_deinit(&dl); | |
| * Add: | |
| .. code-block:: C | |
| err = downloader_deinit(&dl); |
tokangas
reviewed
Nov 21, 2024
umapraseeda
requested changes
Nov 21, 2024
| @@ -3512,7 +3512,7 @@ Jobs not received after reset | |||
|
|
|||
| .. rst-class:: v2-6-2 v2-6-1 v2-6-0 v2-5-3 v2-5-2 v2-5-1 v2-5-0 | |||
|
|
|||
| NCSDK-24305: fota_download library sends FOTA_DOWNLOAD_EVT_FINISHED when unable to connect | |||
| NCSDK-24305: fota_download and fota_download libraries sends FOTA_DOWNLOAD_EVT_FINISHED and FOTA_DOWNLOAD_EVT_FINISHED events, respectively, when unable to connect | |||
There was a problem hiding this comment.
Why 2 entries for the same library and same event? Isn't this about the FOTA download library that is not changed as part of the PR?
| @@ -3521,9 +3521,9 @@ NCSDK-24305: fota_download library sends FOTA_DOWNLOAD_EVT_FINISHED when unable | |||
| .. rst-class:: v1-1-0 | |||
|
|
|||
| Stalled download | |||
| :ref:`lib_fota_download` does not resume a download if the device loses the connection. | |||
| :ref:`lib_fota_download` and :ref:`lib_fota_download` does not resume a download if the device loses the connection. | |||
There was a problem hiding this comment.
Why 2 entries for the same library? Isn't this about the FOTA download library that is not changed as part of the PR?
There was a problem hiding this comment.
My bad, I missed to review this file during the initial review. Also, line nos: 3501, 3502, and 3516 would require an update to :ref:lib_downloader, which mentions :ref:lib_download_client.
|
|
||
| **Workaround:** Call :cpp:func:`fota_download_start` again with the same arguments when the connection is re-established to resume the download. | ||
| **Workaround:** Call :cpp:func:`fota_download_start` or :cpp:func:`fota_download_start` again with the same arguments when the connection is re-established to resume the download. |
There was a problem hiding this comment.
Duplicate entry for the same function
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
eivindj-nordic
force-pushed
the
25700_download_client_rework
branch
6 times, most recently
from
aee34a9
to
8f2d185
Compare
divipillai
reviewed
Nov 25, 2024
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst
Outdated
Show resolved
Hide resolved
eivindj-nordic
force-pushed
the
25700_download_client_rework
branch
3 times, most recently
from
ad19a95
to
8441121
Compare
|
|
||
| #include "dl_parse.h" | ||
|
|
||
| static int swallow(const char **str, const char *swallow) |
There was a problem hiding this comment.
I suggest trim (or strip), I had to go into the code to see what it actually does because it wasn't obvious from the name. Also, generally not recommended to have names that shadow each other (the function swallow and the parameter swallow in the same scope) even though the compiler can figure it out.
Suggested change
| static int swallow(const char **str, const char *swallow) | |
| static int trim(const char **str, const char *substr) |
| { | ||
| switch (state) { | ||
| case DOWNLOADER_IDLE: | ||
| return "IDLE"; |
There was a problem hiding this comment.
Could use the Zephyr macro STRINGIFY here instead of hardcoding a string, same for the other ones.
There was a problem hiding this comment.
Yes, though I would like to avoid logging the full name. For some logs there are multiple states in the same line, so it will be quite long.
| } | ||
| } | ||
|
|
||
| int downloader_init(struct downloader *const dl, |
There was a problem hiding this comment.
Suggested change
| int downloader_init(struct downloader *const dl, | |
| int downloader_init(struct downloader *const dl, struct downloader_cfg *config) |
| /* The thread is spawned now, but it will suspend itself; | ||
| * it is resumed when the download is started via the API. | ||
| */ | ||
| dl->tid = |
There was a problem hiding this comment.
Strange line formatting here.
| return 0; | ||
| } | ||
|
|
||
| int downloader_deinit(struct downloader *const dl) |
There was a problem hiding this comment.
What happens if we pass an uninitialized downloader?
There was a problem hiding this comment.
Good question, I've added some checks for the state, event_sem and thread to be set.
| int downloader_cancel(struct downloader *const dl) | ||
| { | ||
| if (dl == NULL || | ||
| is_state(dl, DOWNLOADER_IDLE) || |
There was a problem hiding this comment.
I think it's better to be explicit about which states are permitted rather than the opposite. From looking at the code here I wouldn't know which states are permitted and would have to see the list of all states and eliminate the ones here. Also, this permits the state DOWNLOADER_STOPPING to be canceled, which seems strange. If it's on purpose, why?
| { | ||
| int rc; | ||
|
|
||
| if (dl == NULL || uri == NULL) { |
There was a problem hiding this comment.
host_config not checked. Yes, it's checked later in downloader_start but now you have coupling between the two functions.
| return -EINVAL; | ||
| } | ||
|
|
||
| k_mutex_lock(&dl->mutex, K_FOREVER); |
There was a problem hiding this comment.
On one hand host_config is not checked because it's done in downloader_start, but then the same should apply to the mutex lock: there is no need to lock here because it is locked inside downloader_start. I think that this lock/unlock can be removed.
| return rc; | ||
| } | ||
|
|
||
| int downloader_get_with_host_and_path(struct downloader *dl, |
There was a problem hiding this comment.
host_and_file perhaps since the other argument is file?
| return -EINVAL; | ||
| } | ||
|
|
||
| sprintf(dl->config.buf, "%s/%s", host, file); |
There was a problem hiding this comment.
Would prefer the more secure snprintf.
eivindj-nordic
force-pushed
the
25700_download_client_rework
branch
from
8441121
to
effe299
Compare
tokangas
reviewed
Nov 27, 2024
| @@ -56,7 +55,9 @@ SHELL_STATIC_SUBCMD_SET_CREATE( | |||
| sub_fota, | |||
| SHELL_CMD_ARG( | |||
| download, NULL, | |||
| "<server> <filename>\nDownload and install a FOTA update. Available servers are \"eu\", \"us\", \"jpn\" and \"au\".", | |||
| "[<server> <filename>]\nDownload and install a FOTA update. " | |||
There was a problem hiding this comment.
Suggested change
| "[<server> <filename>]\nDownload and install a FOTA update. " | |
| "<server> <filename>\nDownload and install a FOTA update. " |
eivindj-nordic
force-pushed
the
25700_download_client_rework
branch
3 times, most recently
from
53bde3d
to
9b9b914
Compare
umapraseeda
reviewed
Nov 27, 2024
| @@ -3520,7 +3520,7 @@ Jobs not received after reset | |||
| .. rst-class:: v2-6-2 v2-6-1 v2-6-0 v2-5-3 v2-5-2 v2-5-1 v2-5-0 | |||
|
|
|||
| NCSDK-24305: fota_download library sends FOTA_DOWNLOAD_EVT_FINISHED when unable to connect | |||
| The :ref:`lib_download_client` library does not resume a download if the device cannot connect to a target server. | |||
| The :ref:`lib_download_client` and :ref:`lib_downloader` libraries does not resume a download if the device cannot connect to a target server. | |||
There was a problem hiding this comment.
Suggested change
| The :ref:`lib_download_client` and :ref:`lib_downloader` libraries does not resume a download if the device cannot connect to a target server. | |
| The :ref:`lib_download_client` and :ref:`lib_downloader` libraries do not resume a download if the device cannot connect to a target server. |
| @@ -38,7 +38,7 @@ HTTPS downloads | |||
| The FOTA download library is used in the :ref:`http_application_update_sample` sample. | |||
|
|
|||
| By default, the FOTA download library uses HTTP for downloading the firmware file. | |||
| To use HTTPS, apply the changes described in :ref:`the HTTPS section of the download client documentation <download_client_https>` to the library. | |||
| To use HTTPS, apply the changes described in :ref:`the HTTPS section of the download client documentation <downloader_https>` to the library. | |||
There was a problem hiding this comment.
Suggested change
| To use HTTPS, apply the changes described in :ref:`the HTTPS section of the download client documentation <downloader_https>` to the library. | |
| To use HTTPS, apply the changes described in :ref:`the HTTPS section of the Downloader library documentation <downloader_https>` to the library. |
| .. note:: | ||
| The new downloader has an API to download the file using the URI directly. | ||
|
|
||
| #. [optional] Deinitlaize the downloader after use: |
There was a problem hiding this comment.
Suggested change
| #. [optional] Deinitlaize the downloader after use: | |
| #. [optional] Deinitialize the downloader after use: |
divipillai
reviewed
Nov 27, 2024
| @@ -3520,7 +3520,7 @@ Jobs not received after reset | |||
| .. rst-class:: v2-6-2 v2-6-1 v2-6-0 v2-5-3 v2-5-2 v2-5-1 v2-5-0 | |||
|
|
|||
| NCSDK-24305: fota_download library sends FOTA_DOWNLOAD_EVT_FINISHED when unable to connect | |||
| The :ref:`lib_download_client` library does not resume a download if the device cannot connect to a target server. | |||
| The :ref:`lib_download_client` and :ref:`lib_downloader` libraries does not resume a download if the device cannot connect to a target server. | |||
There was a problem hiding this comment.
Suggested change
| The :ref:`lib_download_client` and :ref:`lib_downloader` libraries does not resume a download if the device cannot connect to a target server. | |
| The :ref:`lib_download_client` and :ref:`lib_downloader` libraries do not resume a download if the device cannot connect to a target server. |
| @@ -3505,10 +3505,10 @@ NCSDK-11432: DFU: Erasing secondary slot returns error response | |||
| .. rst-class:: v1-7-1 v1-7-0 v1-6-1 v1-6-0 v1-5-2 v1-5-1 v1-5-0 v1-4-2 v1-4-1 v1-4-0 | |||
|
|
|||
| NCSDK-6238: Socket API calls might hang when using Download client | |||
| When using the :ref:`lib_download_client` library with HTTP (without TLS), the application might not process incoming fragments fast enough, which can starve the :ref:`nrfxlib:nrf_modem` buffers and make calls to the Modem library hang. | |||
| When using the :ref:`lib_download_client` and :ref:`lib_downloader` libraries with HTTP (without TLS), the application might not process incoming fragments fast enough, which can starve the :ref:`nrfxlib:nrf_modem` buffers and make calls to the Modem library hang. | |||
| Samples and applications that are affected include those that use :ref:`lib_download_client` to download files through HTTP, or those that use :ref:`lib_fota_download` with modem updates enabled. | |||
There was a problem hiding this comment.
Suggested change
| Samples and applications that are affected include those that use :ref:`lib_download_client` to download files through HTTP, or those that use :ref:`lib_fota_download` with modem updates enabled. | |
| Samples and applications that are affected include those that use :ref:`lib_download_client` and :ref:`lib_downloader` libraries to download files through HTTP, or those that use :ref:`lib_fota_download` with modem updates enabled. |
| Samples and applications that are affected include those that use :ref:`lib_download_client` to download files through HTTP, or those that use :ref:`lib_fota_download` with modem updates enabled. | ||
|
|
||
| **Workaround:** Set :kconfig:option:`CONFIG_DOWNLOAD_CLIENT_RANGE_REQUESTS`. | ||
| **Workaround:** Set :kconfig:option:`CONFIG_DOWNLOAD_CLIENT_RANGE_REQUESTS` with the :ref:`lib_download_client` library. Set ``range_override`` in :c:struct:`downloader_host_cfg` with the :ref:`lib_downloader` library. |
There was a problem hiding this comment.
Suggested change
| **Workaround:** Set :kconfig:option:`CONFIG_DOWNLOAD_CLIENT_RANGE_REQUESTS` with the :ref:`lib_download_client` library. Set ``range_override`` in :c:struct:`downloader_host_cfg` with the :ref:`lib_downloader` library. | |
| **Workaround:** Set :kconfig:option:`CONFIG_DOWNLOAD_CLIENT_RANGE_REQUESTS` for the :ref:`lib_download_client` library. | |
| Set ``range_override`` in :c:struct:`downloader_host_cfg` for the :ref:`lib_downloader` library. |
eivindj-nordic
force-pushed
the
25700_download_client_rework
branch
from
9b9b914
to
670cb2d
Compare
| REQUIRED = 2, | ||
| }; | ||
|
|
||
| verify = REQUIRED; |
There was a problem hiding this comment.
The size of enum is system dependent, I would stick to int which is the type expected by setsockopt.
Instead use:
int verify = TLS_PEER_VERIFY_REQUIRED
There was a problem hiding this comment.
Agreed, updated.
| return 0; | ||
| } | ||
|
|
||
| static int socket_tls_hostname_set(int fd, const char * const host) |
There was a problem hiding this comment.
Suggested change
| static int socket_tls_hostname_set(int fd, const char * const host) | |
| static int socket_tls_hostname_set(int fd, const char * const hostname) |
For consistency since there are other functions that have a hostname parameter named hostname.
| if (err) { | ||
| err = -errno; | ||
| /* Make sure that ECONNRESET is not returned as it has a special meaning | ||
| * in the download client API |
There was a problem hiding this comment.
Perhaps?
Suggested change
| * in the download client API | |
| * in the downloader API |
| return -EINVAL; | ||
| } | ||
|
|
||
| timeo.tv_sec = (timeout_ms / 1000); |
There was a problem hiding this comment.
This logic is shared with send_timeout_set, maybe it can be abstracted?
| */ | ||
|
|
||
| BUILD_ASSERT( | ||
| STACK_SIZE - (HOSTNAME_SIZE + FILENAME_SIZE) >= 512, |
There was a problem hiding this comment.
Is this 512 defined somewhere?
| } | ||
|
|
||
| static int cmd_host_config_sec_tag(const struct shell *shell, size_t argc, | ||
| char **argv) |
| } | ||
|
|
||
| static int cmd_host_config_pdn_id(const struct shell *shell, size_t argc, | ||
| char **argv) |
| SHELL_STATIC_SUBCMD_SET_CREATE(host_config_options, | ||
| SHELL_CMD(sec_tag, NULL, "Set security tag", cmd_host_config_sec_tag), | ||
| SHELL_CMD(pdn_id, NULL, "Set PDN ID", cmd_host_config_pdn_id), | ||
| SHELL_CMD(sec_tag, NULL, "Set security tag", cmd_host_config_sec_tag), |
|
|
||
| static int dl_callback(const struct downloader_evt *event); | ||
|
|
||
| static char dl_buf[2048]; |
There was a problem hiding this comment.
Comment on the 2048 here too like in transports/http.c?
There was a problem hiding this comment.
It is not the same.
| http->sock.proto = IPPROTO_TCP; | ||
| http->sock.type = SOCK_STREAM; | ||
|
|
||
| if (strncmp(uri, "https://", 8) == 0 || |
|
|
||
| static bool dl_http_proto_supported(struct downloader *dl, const char *uri) | ||
| { | ||
| if (strncmp(uri, "https://", 8) == 0) { |
There was a problem hiding this comment.
These two strings and their length are used in multiple places, I would define them at the top and use strlen.
| * Length of data payload left to process on success | ||
| * Negative errno on error. | ||
| */ | ||
| static int http_parse(struct downloader *dl, size_t len) |
There was a problem hiding this comment.
Have you checked if there is already an http parser in Zephyr?
There was a problem hiding this comment.
There is, I'll leave it as a future task to see if that can be used.
https://docs.zephyrproject.org/apidoc/latest/parser_8h.html
| return -EBADMSG; | ||
| } | ||
|
|
||
| expected_status = (http->ranged || dl->progress) ? 206 : 200; |
There was a problem hiding this comment.
These two http status codes can be defined too, mostly for their name/use. For example, I know from the top of my head that 200 is success, but don't remember 206.
| if (err) { | ||
| switch (http->sock.proto) { | ||
| case IPPROTO_TLS_1_2: | ||
| http->sock.port = 443; |
There was a problem hiding this comment.
I would define these two too
eivindj-nordic
force-pushed
the
25700_download_client_rework
branch
3 times, most recently
from
12781ef
to
2db381f
Compare
The new downloader is replacing the download_client library and is based on that. Internal restructuring: * Restructuring of socket functions and files. * Parse HTTP header line for line. This reduces the size requirement for the download client recv buffer. * Change TLS range override logic. * Use range requests for nRF91 TLS only, and when specified by app. API updates: * Let application provide client buffer. This allows for multiple download clients with different buffer sizes. * Add downloader_deinit() * Add downloader_stop() * Remove downloader_disconnect() * Changed signature of downloader_init(), downloader_start() and downloader_get() to take a URI. * Added downloader_get_with_host_and_path() for downloads where host and path are separate arguments to keep backwards compatibility. * The transports (http, coap) are now separated out of the download client with its own API. Future work: * Take uri as input param to fota_download library and use URI in other relevant libaries and structures. * Curent download client is deprecated and will be removed later. Signed-off-by: Eivind Jølsgard <[email protected]>
eivindj-nordic
force-pushed
the
25700_download_client_rework
branch
from
2db381f
to
761cfb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress. No need for thorough review yet.
TODOs