Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New headers #621

Merged
merged 8 commits into from
Dec 3, 2024
Merged

New headers #621

merged 8 commits into from
Dec 3, 2024

Conversation

Deeroil
Copy link
Collaborator

@Deeroil Deeroil commented Nov 29, 2024

Done:

  • headers for locality, species
  • headers for references (not perfect but seemed ok)

TODO

  • other headers
  • docs?
  • tests?

@Deeroil Deeroil self-assigned this Nov 29, 2024
This was linked to issues Nov 29, 2024
User can see additional information from the header of details #362
Closed
Headers should have the same data as in php-version #572
Closed
Docs for PHP-like headers #573
Closed
Tests for PHP-like headers? #574
Closed
@realtalin
Copy link
Collaborator

Headers for Localities, Species, Time Units, Time Bounds and References now have the same data as the PHP version.

@realtalin realtalin marked this pull request as ready for review December 3, 2024 11:07
iritmaximus
iritmaximus approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@iritmaximus iritmaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iritmaximus iritmaximus merged commit ce367df into main Dec 3, 2024
4 checks passed
@iritmaximus iritmaximus deleted the headers branch December 3, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritmaximus iritmaximus iritmaximus approved these changes

Assignees

@Deeroil Deeroil

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Deeroil @realtalin @iritmaximus