Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callgraph: Add effects #227

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Callgraph: Add effects #227

merged 5 commits into from
Dec 2, 2024

Conversation

Esorat
Copy link
Member

@Esorat Esorat commented Nov 25, 2024 •
edited by jubnzv
Loading

Closes #189

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented
  • No test failures were reported when running yarn test-all
  • I did not do unrelated and/or undiscussed refactorings

@Esorat Esorat changed the title WIP: Add extra effects to nodes. Without put in to tact/utils.ts WIP: Add extra effects to nodes Nov 25, 2024
jubnzv
jubnzv requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@jubnzv jubnzv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good start. The overall logic seems quite close to the desired implementation.

src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
@Esorat
Fix: add enum, remake helper functions.
a3325c4 
Chore: add EffectFlags to sendInloop detector.
@jubnzv jubnzv mentioned this pull request Nov 27, 2024
Open
jubnzv
jubnzv requested changes Nov 28, 2024
View reviewed changes
Copy link
Member

@jubnzv jubnzv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you test it? Let's add these effects on the callgraph dump and check all the effects there.

src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
@jubnzv jubnzv self-assigned this Dec 1, 2024
@jubnzv jubnzv changed the title WIP: Add extra effects to nodes Callgraph: Add effects Dec 1, 2024
@jubnzv jubnzv merged commit 21e0af1 into nowarp:master Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubnzv jubnzv jubnzv requested changes

Assignees

@jubnzv jubnzv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Callgraph: Add effects to nodes
2 participants
@Esorat @jubnzv