-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Android release process #1779
Conversation
…roid-release-process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think workflow trigger might be wrong and would trigger release on every push to main
.github/workflows/android-app.yml
Outdated
build: | ||
name: Build | ||
tests: | ||
name: Build android unit tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to revert to Build
for name as this is required check for PR merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Judging by PR status I think it’s still outstanding @Dmitry-Borodin
My suggestion would be to align with iOS release pipeline and switch to manual trigger via CI:
|
./gradlew clean assembleRelease --stacktrace | ||
|
||
- name: Sign app APK | ||
uses: r0adkll/sign-android-release@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repository seems abandoned. Could we use another one?
https://github.com/r0adkll/sign-android-release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ok as signing didn't change - it is very small task and this usually not changed. I've tested it already and current signing working fine. Most probably we will not need to change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It uses deprecated Node12, so one day it'll stop working
https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
r0adkll/sign-android-release#70
@krodak fixed issues you requested to change. Thx for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* release flow work in progress * fix current task description * release flow updated to what it probably should be * keys passed * yaml error fix * yaml error fix 2 * yaml error fix 3 * yaml error fix 4 not relevant * test workflow changes * test workflow changes 2 * workflow descriptions update * renamed jobs * unblock push to store step for test * added cache back and jobs renamed * publish to fix testing * publish to fix 2 * publish to fix 3 * publish to fix 4 * publish to fix 5 * version update to see if we can upload to play store * cleanup release flow after testing of release flow * readme updated about release * review changes * readme updated * updated checkout action version as in other flows * chore: update android existing CI flow --------- Co-authored-by: Krzysztof Rodak <[email protected]>
Purpose
Make release flow in github action instead of manual process in clean room.
Scope
Feedback is welcome.