Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Android release process #1779

Merged
merged 28 commits into from
Apr 14, 2023
Merged

feat: Android release process #1779

merged 28 commits into from
Apr 14, 2023

Conversation

Dmitry-Borodin
Copy link
Contributor

Purpose

Make release flow in github action instead of manual process in clean room.

Scope

  • build and sign APK in github
  • upload release apk to internal track in play store
  • readme updated of how we can release now.

Feedback is welcome.

Copy link
Contributor

@krodak krodak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think workflow trigger might be wrong and would trigger release on every push to main

build:
name: Build
tests:
name: Build android unit tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to revert to Build for name as this is required check for PR merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done. Thank you.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Judging by PR status I think it’s still outstanding @Dmitry-Borodin

.github/workflows/android-release.yml Outdated Show resolved Hide resolved
.github/workflows/android-release.yml Outdated Show resolved Hide resolved
@krodak
Copy link
Contributor

krodak commented Apr 13, 2023

My suggestion would be to align with iOS release pipeline and switch to manual trigger via CI:

on:
 workflow_dispatch:

./gradlew clean assembleRelease --stacktrace

- name: Sign app APK
uses: r0adkll/sign-android-release@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repository seems abandoned. Could we use another one?
https://github.com/r0adkll/sign-android-release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ok as signing didn't change - it is very small task and this usually not changed. I've tested it already and current signing working fine. Most probably we will not need to change it.

Copy link
Contributor

@prybalko prybalko Apr 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/android-release.yml Outdated Show resolved Hide resolved
@Dmitry-Borodin
Copy link
Contributor Author

@krodak fixed issues you requested to change. Thx for review.

Copy link
Contributor

@krodak krodak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dmitry-Borodin Dmitry-Borodin merged commit 0e709a8 into master Apr 14, 2023
@Dmitry-Borodin Dmitry-Borodin deleted the android-release-process branch April 14, 2023 02:27
Dmitry-Borodin added a commit that referenced this pull request Apr 14, 2023
* release flow work in progress

* fix current task description

* release flow updated to what it probably should be

* keys passed

* yaml error fix

* yaml error fix 2

* yaml error fix 3

* yaml error fix 4 not relevant

* test workflow changes

* test workflow changes 2

* workflow descriptions update

* renamed jobs

* unblock push to store step for test

* added cache back and jobs renamed

* publish to fix testing

* publish to fix 2

* publish to fix 3

* publish to fix 4

* publish to fix 5

* version update to see if we can upload to play store

* cleanup release flow after testing of release flow

* readme updated about release

* review changes

* readme updated

* updated checkout action version as in other flows

* chore: update android existing CI flow

---------

Co-authored-by: Krzysztof Rodak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants