Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup staking proxy #935

Merged
merged 10 commits into from
Jan 23, 2024
Merged

Setup staking proxy #935

merged 10 commits into from
Jan 23, 2024

Conversation

lynx56
Copy link
Contributor

@lynx56 lynx56 commented Jan 11, 2024 •
edited
Loading

combine_images-28

@lynx56 lynx56 marked this pull request as draft January 11, 2024 08:19
ERussel
ERussel reviewed Jan 11, 2024
View reviewed changes
Copy link
Collaborator

@ERussel ERussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also didn't notice where we check that we have permissions for staking

@lynx56 lynx56 marked this pull request as ready for review January 11, 2024 12:36
@lynx56 lynx56 requested a review from ERussel January 11, 2024 12:48
@lynx56 lynx56 changed the base branch from base/proxy to feature/add-staking-proxy January 11, 2024 12:54
@ERussel ERussel merged commit ae63f45 into feature/add-staking-proxy Jan 23, 2024
3 checks passed
@ERussel ERussel deleted the feature/setup-staking-proxy branch January 23, 2024 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ERussel ERussel ERussel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lynx56 @ERussel