Split screen layout for browser widget PoC #1277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svojsu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC implementation of a split-screen layout with browser widget:
NovaMainAppContainerserves as the main container forMainTabBarandBrowserWidgetmodulesBrowserWidgetview for appearance/disappearance animations. The entire module implements tab observation logic to maintain the current stateNovaMainAppContainerhides theBrowserWidgetview and shows a separate UIWindow with an identical view, allowing us to keep our widget visible regardless of which modal controllers are presentedNovaMainAppContainerholds actions of widget's view and passes it straight toBrowserWidgetmoduletrim.9BC4A658-ED71-4C1A-9FB0-08EABE079FBE.MOV