Skip to content

Commit

Permalink
patch-tool-mxe: provide message when calling "git tag"
Browse files Browse the repository at this point in the history
`git tag something` will invoke the editor. As the editor is invoked
via `make`, it doesn't have a TTY to display stuff on. In the case of
`vim`, this means `vim` hangs in the background indefinitely, as does
`make` waiting for `vim` to finish. The user has no way to interact
with that editor instance, having to kill it, which in turn causes
`git tag` and ultimately `make` to fail.

Fixes mxe#2739.
  • Loading branch information
mbunkus authored and mabrand committed Jan 13, 2022
1 parent fc6f4f5 commit 43bb17c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mxe.patch.mk
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ define INIT_GIT
$(call GIT_CMD,$(1)) init
$(call GIT_CMD,$(1)) add -A -f
$(call GIT_CMD,$(1)) commit -m "init"
$(call GIT_CMD,$(1)) tag dist
$(call GIT_CMD,$(1)) tag -m "dist" dist
endef

define IMPORT_PATCH
Expand Down

0 comments on commit 43bb17c

Please sign in to comment.