Use HTML template #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gael-ian
added a commit
that referenced
this pull request
Mar 7, 2023
* Replace association-insertion-template data attribute by an HTML template * Rewrite JavaScript Builder to use a DOM DocumentFragment as its source * Use the new Builder and adapt tests * Use a data attribute instead of ID to identify template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step to remove the dependency to jQuery (See #4), this replace nested item building strategy to use an HTML
templatetag instead of relying on the magic of$(templateString).cocooned_add_item_linknow generates the appropriatetemplatetag aside its link and the javascript builder has been rewritten to change the value of anyfor,idornameattribute in the DOM subtree cloned from template content.