feat: add blockchain traits module with esplora_async impl #460
GitHub Actions / clippy
failed
Sep 30, 2023 in 0s
clippy
3 errors
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 3 |
Warning | 0 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.67.0 (fc594f156 2023-01-24)
- cargo 1.67.0 (8ecd4f20a 2023-01-10)
- clippy 0.1.67 (fc594f1 2023-01-24)
Annotations
Check failure on line 110 in crates/bdk/src/blockchain/esplora_async.rs
github-actions / clippy
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeMap`
error: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeMap`
--> crates/bdk/src/blockchain/esplora_async.rs:110:18
|
110 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
= note: `-D clippy::into-iter-on-ref` implied by `-D warnings`
Check failure on line 100 in crates/bdk/src/blockchain/esplora_async.rs
github-actions / clippy
`Box::new(_)` of default value
error: `Box::new(_)` of default value
--> crates/bdk/src/blockchain/esplora_async.rs:100:45
|
100 | let mut spks: Box<Vec<ScriptBuf>> = Box::new(Vec::new());
| ^^^^^^^^^^^^^^^^^^^^ help: try: `Box::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
= note: `-D clippy::box-default` implied by `-D warnings`
Check failure on line 26 in crates/bdk/src/blockchain/esplora_async.rs
github-actions / clippy
useless conversion to the same type: `&bitcoin::Transaction`
error: useless conversion to the same type: `&bitcoin::Transaction`
--> crates/bdk/src/blockchain/esplora_async.rs:26:31
|
26 | self.client.broadcast(tx.into()).await
| ^^^^^^^^^ help: consider removing `.into()`: `tx`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
Loading