feat: add blockchain traits module with esplora_async impl #461
Annotations
3 errors and 3 warnings
this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeMap`:
crates/bdk/src/blockchain/esplora_async.rs#L113
error: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `BTreeMap`
--> crates/bdk/src/blockchain/esplora_async.rs:113:18
|
113 | .into_iter()
| ^^^^^^^^^ help: call directly: `iter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
= note: `-D clippy::into-iter-on-ref` implied by `-D warnings`
|
`Box::new(_)` of default value:
crates/bdk/src/blockchain/esplora_async.rs#L103
error: `Box::new(_)` of default value
--> crates/bdk/src/blockchain/esplora_async.rs:103:45
|
103 | let mut spks: Box<Vec<ScriptBuf>> = Box::new(Vec::new());
| ^^^^^^^^^^^^^^^^^^^^ help: try: `Box::default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#box_default
= note: `-D clippy::box-default` implied by `-D warnings`
|
useless conversion to the same type: `&bitcoin::Transaction`:
crates/bdk/src/blockchain/esplora_async.rs#L26
error: useless conversion to the same type: `&bitcoin::Transaction`
--> crates/bdk/src/blockchain/esplora_async.rs:26:31
|
26 | self.client.broadcast(tx.into()).await
| ^^^^^^^^^ help: consider removing `.into()`: `tx`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
= note: `-D clippy::useless-conversion` implied by `-D warnings`
|
security_audit
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/audit-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
security_audit
1 warnings found!
|
security_audit
Unknown warning kind unsound found, please, file a bug
|