Skip to content

Commit

Permalink
fix: resolve comments for Patrick
Browse files Browse the repository at this point in the history
Signed-off-by: Junjie Gao <[email protected]>
  • Loading branch information
JeyJeyGao committed Jan 7, 2025
1 parent ec7fe13 commit 4d13267
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions cmd/notation/blob/cmd.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ import (
func Cmd() *cobra.Command {
command := &cobra.Command{
Use: "blob [command]",
Short: "Sign, inspect, and verify signatures and configure trust policies",
Long: "Sign, inspect, and verify signatures and configure trust policies.",
Short: "Sign, inspect, verify signatures, and configure trust policies for blob artifacts",
Long: "Sign, inspect, verify signatures, and configure trust policies for blob artifacts.",
}

command.AddCommand(
Expand Down
4 changes: 2 additions & 2 deletions cmd/notation/blob/policy/import.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ func importCmd() *cobra.Command {
Example - Import blob trust policy configuration from a file:
notation blob policy import my_policy.json
Example - Import blob trust policy and override existing configuration:
Example - Import blob trust policy and override existing configuration without prompt:
notation blob policy import my_policy.json --force
`,
Args: func(cmd *cobra.Command, args []string) error {
Expand All @@ -54,7 +54,7 @@ Example - Import blob trust policy and override existing configuration:
return runImport(opts)
},
}
command.Flags().BoolVar(&opts.force, "force", false, "override the existing blob trust policy configuration, never prompt")
command.Flags().BoolVar(&opts.force, "force", false, "override the existing blob trust policy configuration without prompt")
return command
}

Expand Down
2 changes: 1 addition & 1 deletion cmd/notation/blob/policy/show.go
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func runShow() error {
err = doc.Validate()
}
if err != nil {
fmt.Fprintf(os.Stderr, "Existing blob trust policy file is invalid, you may update or create a new one via `notation blob policy import <path-to-policy.json>`. Please visit https://github.com/notaryproject/specifications/blob/main/specs/trust-store-trust-policy.md#trust-policy-for-blobs to find a valid blob trust policy example.\n")
fmt.Fprintf(os.Stderr, "Existing blob trust policy file is invalid, you may update or create a new one via `notation blob policy import <path-to-policy.json>`. See https://github.com/notaryproject/specifications/blob/main/specs/trust-store-trust-policy.md#trust-policy-for-blobs for a blob trust policy example.\n")
os.Stdout.Write(policyJSON)
return err
}
Expand Down

0 comments on commit 4d13267

Please sign in to comment.