Problem: can claim problems with open children

src/components/problems/LogNewProblemModal.svelte

@@ -41,8 +41,9 @@
   onMount(()=>{
     if (existing){
       newProblem = existing.Copy()
-    } else {
+    } else if (parent) {
       newProblem = new Problem()
+      newProblem.Parents.add(parent.UID)
     }
   })
 
@@ -82,13 +83,18 @@
         rocket: newProblem.Rocket, //todo check parent problem's rocket and use that here
       });
       e.tags.push(["text", newProblem.Title, "tldr"]);
-      e.tags.push(["text", newProblem.Summary, "paragraph"]);
-      e.tags.push(["text", newProblem.FullText, "page"]);
+      if (newProblem.Summary) {
+        e.tags.push(["text", newProblem.Summary, "paragraph"]);
+      }
+      if (newProblem.FullText) {
+        e.tags.push(["text", newProblem.FullText, "page"]);
+      }
       newProblem.Parents.forEach(p=>{
         e.tags.push(["e", p, "", "parent"]);
       })
       if (parent && !existing) {
         e.tags.push(["new"]);
+
       }
       if (!parent && existing) {
         e.tags.push(["e", existing.UID, "problem"])

src/lib/stores/nostrocket_state/soft_state/simplifiedProblems.ts

@@ -2,6 +2,9 @@ import { labelledTag } from "$lib/helpers/shouldBeInNDK";
 import type { NDKEvent } from "@nostr-dev-kit/ndk";
 import { nostrocketIgnitionEvent, rootProblem } from "../../../../settings";
 import { Problem, type Nostrocket } from "../types";
+import { consensusTipState } from "../master_state";
+import { get } from "svelte/store";
+import { tr } from "date-fns/locale";
 
 export function HandleProblemEvent(
   ev: NDKEvent,
@@ -72,6 +75,7 @@ function handleProblemStatusChangeEvent(
     return "you cannot mark this problem as patched unless you are the one who claimed it";
   }
   if (newStatus == "claimed") {
+    if (hasOpenChildren(problem, state)) {return "this problem has open children, it cannot be claimed"}
     state.Problems.forEach((p) => {
       if (p.Status == "claimed" && p.ClaimedBy == ev.pubkey) {
         return (
@@ -226,6 +230,16 @@ function populateChildren(problem: Problem, state: Nostrocket) {
   });
 }
 
+export function hasOpenChildren(problem:Problem, state:Nostrocket):boolean {
+  let has = false
+  if (!state) {state = get(consensusTipState)}
+  problem?.Children.forEach(p=>{
+    if (state.Problems.get(p)?.Status != "closed") {
+      has = true
+    }
+  })
+  return has
+}
 //// Legacy stuff for reference, leave here for G to delete:
 // function updateProblemWithNewHead(
 //     current: Problem,

src/routes/problems/[id]/+page.svelte

@@ -23,7 +23,7 @@
   import { AcceleratedComputing, DesignLeadership, DoNot, Idea, Management } from "carbon-pictograms-svelte";
   import { get } from "svelte/store";
   import LogNewProblemModal from "../../../components/problems/LogNewProblemModal.svelte";
-  import { HandleProblemEvent } from "$lib/stores/nostrocket_state/soft_state/simplifiedProblems";
+  import { HandleProblemEvent, hasOpenChildren } from "$lib/stores/nostrocket_state/soft_state/simplifiedProblems";
 
   let problem: Problem | undefined;
   let createdBy: NDKUserProfile | undefined;
@@ -124,12 +124,12 @@
           <p
             style="display: flex; align-items: center; text-transform: capitalize"
           >
-            {#if problem?.Status == "open" && problem.Children.size > 0}<span
+            {#if problem?.Status == "open" && hasOpenChildren(problem, $consensusTipState)}<span
                 style="color:blueviolet"
                 ><Management /> HAS OPEN CHILDREN</span
               >
             {/if}
-            {#if problem?.Status == "open" && problem.Children.size == 0}<span
+            {#if problem?.Status == "open" && !hasOpenChildren(problem, $consensusTipState)}<span
                 style="color:green"><Idea /> OPEN AND CAN BE CLAIMED</span
               >
             {/if}