Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hints to nip 25 #1702

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

staab
Copy link
Member

@staab staab commented Jan 20, 2025

Currently most reaction tags have only one argument, but there are many out there that follow NIP 10, including a relay hint and marker. But I think the marker is basically meaningless in this context.

@staab staab marked this pull request as ready for review January 20, 2025 15:48
@vitorpamplona
Copy link
Collaborator

Ack.

Just keep in mind that e tags have been forked into two kinds, kind 10 ones that have a marker and the other that has a pubkey.

@fiatjaf
Copy link
Member

fiatjaf commented Jan 20, 2025

Just keep in mind that e tags have been forked into two kinds, kind 10 ones that have a marker and the other that has a pubkey.

what do you mean? kind 10? you mean NIP-10? but NIP-10 is the one that mentions pubkeys, they come after the marker.

@vitorpamplona
Copy link
Collaborator

Sorry, yes, nip 10, which is referenced by a bunch of other nips.

I think each nip will need to redeclare e to specify which one they are using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants