-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Chunking #49
base: master
Are you sure you want to change the base?
Add Chunking #49
Conversation
… density and isovalues
Comment typos Co-authored-by: Norman Paniagua <[email protected]>
That's a pretty cool approach, I like the idea. |
It's one of the techniques we discussed in #46 based on that in the Volume GFX blog. This is just a basic implementation. The full implementation also uses marching squares to join the chunks of different resolutions and get rid of the holes. |
I believe that all tests are now passing and that it is ready for review. I wasn't aware that the doc examples would be compiled and tested like that. It's rather neat, maybe I can add more documentation. |
Definitely we should add some documentation, I would suggest to document what you think is harder to understand without some short explanation (and example if is needed) because at this stage it is most likely that things will change and maintain the docs up to date with fast changing code is sometimes difficult. |
Ok then :). I think I have this new code already fairly well documented and once this is merged I'll maybe open another PR with doc on my other code too |
Cool, let me know when the PR is ready to review. |
This PR? I think its fine to review now |
This PR adds some chunking functionality
LOD.mp4