Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow --token when default token path doesn't exist in CLI #198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

drake-nominal
Copy link
Contributor

When CLI methods used @nominal.cli.utils.client_options, if the user does not yet have a ~/.nominal.yml and instead provides a --token manually, it would error out. Now, we allow the file to not exist at the click level, and instead manually verify that the path exists if the user also did not pass in an auth token.

@drake-nominal drake-nominal requested a review from wmgroot January 18, 2025 01:03
Copy link
Collaborator

@stefanv stefanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me that --token should taken higher precedence than file-based configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants