Skip to content

Commit

Permalink
Merge pull request #4 from nomad-coe/remove-quippy
Browse files Browse the repository at this point in the history
Remove quippy
  • Loading branch information
ladinesa authored Aug 15, 2024
2 parents f594bd6 + 11746a3 commit 05c632c
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ readme = "README.md"
authors = [{ name = "The NOMAD Authors" }]
license = { text = "Apache-2.0" }
dependencies = [
"quippy-ase==0.9.14",
"nomad-lab>=1.2.0",
]

Expand Down
9 changes: 5 additions & 4 deletions soapnormalizer/normalizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,6 @@ def normalize_system(self, archive: EntryArchive, system, is_representative):
if system.atoms is None:
return False

if not descriptors:
self.logger.warning('SOAP normalizer runs, but quippy is not installed.')
return False

# TODO compute descriptors for primitive system, need to discuss how to store this stuff.
# repr_symmetry = system.symmetry[0]
# print(repr_symmetry)
Expand All @@ -67,6 +63,11 @@ def normalize_system(self, archive: EntryArchive, system, is_representative):
soap.r_cut = np.float64(params['soap cutoff'])
soap.atom_sigma = np.float64(params['atom_sigma'])

system.descriptors.soap = soap
if not descriptors:
# self.logger.warning('SOAP normalizer runs, but quippy is not installed.')
return False

# # regular soap
# quippy_str = params_to_quippy_str(params)
# desc = descriptors.Descriptor(quippy_str)
Expand Down

0 comments on commit 05c632c

Please sign in to comment.