-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gaussian basis set #223
Conversation
Pull Request Test Coverage Report for Build 9285765274Details
💛 - Coveralls |
Hi there, I cannot see this upload, but is this the last one by Akseli Mansikkamäki (https://nomad-lab.eu/prod/v1/gui/upload/id/MASTxxsySg-SkFffP9j2Zw)? Do you know details on the data? I think he is studying magnetism in charged molecules, but I'd like to make sure. |
Neither I can see the upload. @ladinesa Could you ask permissions to share the raw files or have us included? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is okay for a quick fix. If I could take a look at the error or the raw files, I could probabaly hunt down the real reason.
In the past, there were issues matching the basis set specification due to Gaussian's formatting.
electronicparsers/gaussian/parser.py
Outdated
BasisSetContainer( | ||
type='atom-centered orbitals', | ||
scope=['wavefunction'], | ||
basis_set=[bs], | ||
basis_set=[bs] if bs is not None else [], | ||
) | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can leave out the entire BasisSetContainer
if the requirement stands.
@ladinesa Okay, I got access to the failing upload. You made the right call: there simply isn't any basis set mentioned.
Still, this is pretty bad practice on Gaussian's side, as SCF routines shouldn't tacitly assume the basis set. |
@JosePizarro3 Regarding the upload you linked, all the Gaussian files parsed well there. We either add a schema there, or we harden the parsing not to fail for unrecognized methods. |
Digging further, the default is STO-3G. I can see to improve on the current correction then. |
- Remove `None` clauses
@ndaelman there is a problematic test. is it possible for you to look at it so we can merge it already? thanks |
- Remove double check with `basis_set_mappings`
- only add the default when no other basis sets are present - do not allow uncaught settings to be added as basis sets
- Specify return type `resolve_basis_set`
So, some final comments here that will lead to new issues:
|
A parsing error for gaussian has been reported for this upload . The basis set cannot be resolved so I simply set it to None, but @ndaelman-hu you should know more.
The method normalizer also fails so I put up a fix in nomad.