-
Notifications
You must be signed in to change notification settings - Fork 10
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for initial model names in w2dynamics (#175)
Fixed w2dynamics file naming for the initial model Added try for hopping_matrix.value in Wannier90 parser
- Loading branch information
1 parent
d8a1350
commit 306e42a
Showing
2 changed files
with
60 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
306e42a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please fix the error? Ideally, we put up an mr in order to avoid failures in develop.
306e42a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the error comes from the nomad side, not sure what changed.
306e42a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I put the pr, but being a small change, I didn't want to bother with a minor review. The pipeline passed, and the tests locally passed.
Maybe something related with what Ahmed Ilyas added into nomad?
306e42a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah i see, sorry. i manage to fix it