Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set max number of times we search from an old artifact #9

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Dec 6, 2024

Description

Problem*

It takes a while to search for an old artifact when creating a new report.

Summary*

Pull over a change from https://github.com/noir-lang/noir-bench-report which sets an upper bound for the number of times we search for an artifact.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member

Can you change this to take the limit in as a parameter just to avoid us having to make changes in future to unblock an issue?

@TomAFrench
Copy link
Member

We can leave the default as a hundreds so we don't need to pass it in every single time though

@TomAFrench TomAFrench merged commit 10f066e into main Dec 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants