Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for memory report #7

Closed
wants to merge 13 commits into from
Closed

feat: add support for memory report #7

wants to merge 13 commits into from

Conversation

guipublic
Copy link

Description

Problem*

Related to Noir issue #6604

Summary*

Generates a markdwon memory report from json report

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member

I'd like to keep the scope of this action focused more on reporting on Noir metrics rather than it being a generic reporting action. Could you fork this if we want to add tracking of memory?

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep this action targetted at Noir developers while memory reports are only useful for the Noir compiler developer team. We should create a separate action for this.

@TomAFrench
Copy link
Member

Closing as we have the noir-bench-diffs repo now.

@TomAFrench TomAFrench closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants