feat!: remove redefinition of arithmetic methods on BigNumTrait
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, it seems tests run against 0.36.0 which didn't have parent traits (or, well, did in the syntax, but didn't do anything with them) so right now it's impossible to move this PR forward. |
TomAFrench
reviewed
Jan 2, 2025
|
Closes #34 |
TomAFrench
changed the title
BigNumTrait
2 tasks
5 tasks
TomAFrench
approved these changes
Jan 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
While working on having Noir require traits to be in scope I noticed this new error pops up in a usage of this library:
We could import the corresponding trait, but I realized the traits here maybe meant to have
Add,Neg, etc., as parent traits except that until recently it was impossible.As a bonus, now we can use
+,-, etc. with big nums.Summary
Additional Context
PR Checklist
cargo fmton default settings.