chore: added the benchmark tools #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
reviewed
Dec 9, 2024
.github/workflows/benchmarks.yml
Outdated
Comment on lines
19
to
25
| with: | ||
| toolchain: 0.36.0 | ||
|
|
||
| - name: Install bb | ||
| run: | | ||
| npm install -g bbup | ||
| bbup -nv 0.36.0 |
There was a problem hiding this comment.
completely forgot about this, gonna get done with it now. should I update to 1.0?
There was a problem hiding this comment.
bumped the version to 1.0.0-beta.0
gates_report.json
Outdated
There was a problem hiding this comment.
We should add this to .gitignore
.github/workflows/benchmarks.yml
Outdated
| on: | ||
| push: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
Suggested change
| - master | |
| - main |
The default branch is different in this repo.
|
@TomAFrench so the annoying thing is, that it tries to compare the results with the report on main. however, there's currently no gate-report on main. this will happen each time we add a new |
|
That's fine, you can just read the gates report json file locally. You won't have the diffs generated automatically but it should be good enough. |
TomAFrench
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.