fs: keep return type of options.filter in cpsync consistent with doc

nodejs · Apr 11, 2024 · dd46bce · dd46bce
1 parent 52f8dcf
commit dd46bce
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/lib/internal/fs/cp/cp-sync.js b/lib/internal/fs/cp/cp-sync.js
@@ -46,7 +46,6 @@ const {
   parse,
   resolve,
 } = require('path');
-const { isPromise } = require('util/types');
 
 function cpSyncFn(src, dest, opts) {
   // Warn about using preserveTimestamps on 32-bit node
@@ -64,7 +63,7 @@ function cpSyncFn(src, dest, opts) {
 function checkPathsSync(src, dest, opts) {
   if (opts.filter) {
     const shouldCopy = opts.filter(src, dest);
-    if (isPromise(shouldCopy)) {
+    if (typeof shouldCopy !== 'boolean') {
       throw new ERR_INVALID_RETURN_VALUE('boolean', 'filter', shouldCopy);
     }
     if (!shouldCopy) return { __proto__: null, skipped: true };