Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the node-gyp alpine docs section to account for Node 18 in Alpine 3.20 python issue #2099

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Update the node-gyp alpine docs section to account for Node 18 in Alpine 3.20 python issue #2099

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/BestPractices.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ Here is an example of how you would install dependencies for packages that requi
```Dockerfile
FROM node:alpine

RUN apk add --no-cache --virtual .gyp python3 make g++ \
RUN apk add --no-cache --virtual .gyp python3 py-setuptools make g++ \
&& npm install [ your npm dependencies here ] \
&& apk del .gyp
```
Expand Down