Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin markdown-link-check to v3.11.0 on GitHub Actions #2067

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

PeterDaveHello
Copy link
Member

Description

Pin markdown-link-check to v3.11.0 in the GitHub Actions workflow to avoid incorrect 404 errors on existing section links.

Motivation and Context

Starting from markdown-link-check v3.12.1, there is a bug where it incorrectly reports 404 errors for valid existing section links in Markdown files, while v3.11.2 and older do not have this issue, as seen in the CI log:

https://github.com/nodejs/docker-node/actions/runs/8650084895/job/23717794438?pr=2066

To ensure our CI continues to function correctly without these false positive 404 errors, this PR pins the markdown-link-check version to v3.11.0 in the GitHub Actions workflow file.

Testing Details

The changes in this PR were tested by running the updated GitHub Actions workflow on a test branch. The previously occurring false positive 404 errors no longer appear after pinning markdown-link-check to v3.11.0.

Types of changes

  • Documentation
  • Version change (Update, remove or add more Node.js versions)
  • Variant change (Update, remove or add more variants, or versions of variants)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (none of the above)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • All new and existing tests passed.

Pin to v3.11.0 in GitHub Actions workflow to avoid false positive 404 
errors in CI.

Refs:
- tcort/markdown-link-check#250
@PeterDaveHello PeterDaveHello force-pushed the Pin-markdown-link-check branch from 4ced553 to 715034c Compare April 11, 2024 16:59
@LaurentGoderre LaurentGoderre merged commit 2680694 into main Apr 11, 2024
2 checks passed
@LaurentGoderre LaurentGoderre deleted the Pin-markdown-link-check branch April 11, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants