Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: custom registry with path after base url #506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: custom registry with path after base url #506

wants to merge 1 commit into from

Commits on Jun 28, 2024

  1. fix: custom registry with path after base url 

    when using a custom registry with a path after the base URL
(like `https://registry.example.org/with-path/npm`) and using
COREPACK_NPM_TOKEN corepack would not set the Bearer token correctly for
the file download (it did set it for downloading jsons).

while fixing it I also saw that the logic for setting the bearer token
was duplicated. I removed the duplicated logic, always setting the
bearer in the same place and removed the strange condition for checking
the origin (it is not checked when using username password, why then
check when using the token?)

some additional minor changes make the code intent clearer IMHO
    @jorjao81
    jorjao81 committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    586a346 View commit details
    Browse the repository at this point in the history