Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for Windows compilation. #98

Open
wants to merge 3 commits into
base: windows7
Choose a base branch
from

Conversation

LiamKarlMitchell
Copy link
Collaborator

Tested on Windows 7, Could compile in release mode with winpcap developer kit.
Need to use wpcap.lib instead of pcap.lib. I am not sure how to change this in the binding gyp file.

@LiamKarlMitchell
Copy link
Collaborator Author

Darn I am now just getting the error.

WinPcap version 4.1.3 (packet.dll version 4.1.0.2980), based on libpcap version 1.0 branch 1_0_rel0b (20091008)
\Device\NPF_{0E1FCFD9-0532-45C5-A3EB-7179F7830653} /192.168.196.1/255.255.255.0
\Device\NPF_{1F57BC32-DCE2-4437-ABEB-8C87D9849E65} /0.0.0.0/255.0.0.0
\Device\NPF_{3FDF918A-C004-4786-9321-9DEA5B7382CD} /192.168.111.1/255.255.255.0
* \Device\NPF_{9E0F1C3E-59DD-4948-9560-E40CEB96B781} 10.1.1.10/255.255.255.0
Assertion failed: 0, file g:\jenkins\workspace\nodejs-msi\d73b0901\deps\uv\src\win\req-inl.h, line 219

Which I have narrowed down as being effective when uv_poll_start is called in SocketWatcher::Start.

Which means there is an event that is not handled in the switch case there.

UV_READ, UV_WRITE, UV_ACCEPT, UV_CONNECT, UV_SHUTDOWN, UV_UDP_RECV, UV_UDP_SEND, UV_WAKEUP, UV_SIGNAL_REQ, UV_POLL_REQ, UV_GETADDRINFO, UV_PROCESS_EXIT, UV_FS, UV_WORK, UV_FS_EVENT_REQ

Will continue to investigate.

Also fixed a bug? where program would just exit when trying to write
NULL value as String::New(NULL);
@LiamKarlMitchell
Copy link
Collaborator Author

Upgraded to node v0.10.28 and it works. Just have to figure out why I am not getting addresses such as addr, netmask, broadaddr, dstaddr. Possibly the workaround i am using for inet_ntop is wrong.

Now it gets the addresses back.
@LiamKarlMitchell
Copy link
Collaborator Author

Or maybe we can reuse node's function for inet_ntop?
https://github.com/joyent/node/blob/master/deps/uv/src/inet.c
Thoughts?

@mranney
Copy link
Collaborator

mranney commented Jan 11, 2016

Hi there. Thanks for the contribution. I've added you as a collaborator on this project. Feel free to merge as you see fit. Getting proper Windows support would be great for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants