-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support cjs and esm both by tshy #6
Conversation
BREAKING CHANGE: drop Node.js < 18.19.0 support part of eggjs/egg#3644 eggjs/egg#5257
Warning Review failedThe pull request is closed. WalkthroughThe updates encompass multiple files, introducing enhanced TypeScript integration, updated Node.js version support, CI/CD adjustments, and various test and linting improvements. Significant alterations include transitioning from CommonJS to ES module imports, refining the build and export configuration, and updating license, README, and ignore files for better developer experience and compliance. These changes collectively modernize the codebase and streamline development workflows. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6 +/- ##
==========================================
+ Coverage 95.65% 97.14% +1.49%
==========================================
Files 1 1
Lines 46 70 +24
Branches 0 16 +16
==========================================
+ Hits 44 68 +24
Misses 2 2 ☔ View full report in Codecov by Sentry. |
[skip ci] ## [3.0.0](v2.0.0...v3.0.0) (2024-06-23) ### ⚠ BREAKING CHANGES * drop Node.js < 18.19.0 support part of eggjs/egg#3644 eggjs/egg#5257 ### Features * support cjs and esm both by tshy ([#6](#6)) ([30acc65](30acc65))
BREAKING CHANGE: drop Node.js < 18.19.0 support
part of eggjs/egg#3644
eggjs/egg#5257
Summary by CodeRabbit
New Features
LICENSE
to include the MIT License text.Chores
CODECOV_TOKEN
secret..gitignore
to ignore new patterns.Documentation
README.md
to update import statements and function signatures.Refactor
test
files to use ES modules and improved test descriptions and assertions.Configuration
package.json
for Node.js version requirement, script commands, and dev dependencies.tsconfig.json
for stricter typing and ES2022 targeting.