Fix severe node performance issue due to buffer allocation bug, fix undefined behavior which breaks node > 18.7.0#82

Open

afreer wants to merge 3 commits intonode-ffi-napi:latestfrom afreer:feature/afreer/fix-node-18.8

+11-4

Commits on Sep 19, 2023

Change to using std::min() when allocating Buffers on the C++ side. This will result in Buffers being allocated to the size requested up to kMaxLength (0x3fffffff) instead of the current behavior o…

doggkruse
authored and
afreer
committed
Handle case where the previously allocated array buffer is shorter than the current request. This is likely what drove the problematic max size allocation

doggkruse
authored and
afreer
committed
src/binding.cc:WrapPointer(): Fix bug in Node.js > 18.7.0, ensure length is non-zero for non-null pointers.
afreer
committed