Split distribute-cores-and-objectfifos pass in 2 #914
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know @Abhishek-Varma proposed a more dramatic version of this PR previously #452 but I think that the place I'm choosing to split this pass in 2 in reasonable -- basically I'm just separating out the logic which assigns tiles to logicalobjectfifos from everything else i.e. the only thing that changes in the second pass is
becomes
The code copied between .cpp files is completely unmodified, a 100% cut-paste.
I'd like to improve the tests in a second PR.
I will polish this (add comments for the TODOs) if the proposal seems ok.