Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split distribute-cores-and-objectfifos pass in 2 #914

Closed

Conversation

newling
Copy link
Contributor

@newling newling commented Nov 21, 2024

I know @Abhishek-Varma proposed a more dramatic version of this PR previously #452 but I think that the place I'm choosing to split this pass in 2 in reasonable -- basically I'm just separating out the logic which assigns tiles to logicalobjectfifos from everything else i.e. the only thing that changes in the second pass is

 %0 = amdaie.logicalobjectfifo.from_memref %alloc, {} : ... 

becomes

 %0 = amdaie.logicalobjectfifo.from_memref %alloc, {%tile} : ... 

The code copied between .cpp files is completely unmodified, a 100% cut-paste.

I'd like to improve the tests in a second PR.

I will polish this (add comments for the TODOs) if the proposal seems ok.

@yzhang93
Copy link
Contributor

I think @jtuyls was also working on tile assignments as a separate pass and already had a draft. We need something more sophisticated when assigning multiple memTiles and shimTiles.

@jtuyls
Copy link
Collaborator

jtuyls commented Nov 21, 2024

I think @jtuyls was also working on tile assignments as a separate pass and already had a draft. We need something more sophisticated when assigning multiple memTiles and shimTiles.

Yes, I will be putting up a PR later today which has this, but with a bunch of changes in the tile assignment for 4x4.

@newling
Copy link
Contributor Author

newling commented Nov 21, 2024

Ok, will close this and take a look at #915

@newling newling closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants