[CI] Add new shape and with/without ukernel for benchmark tracking #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtuyls
reviewed
Nov 18, 2024
build_tools/ci/cpu_comparison/run.py
Outdated
Comment on lines
1028
to
1066
| 512, | ||
| 512, | ||
| 4096, |
There was a problem hiding this comment.
It should be M == 512, N == 4096, K == 512 to correspond to the problem size we're tracking.
There was a problem hiding this comment.
Please tell me all the sizes we're tracking (sorry I lost the link to the doc again). I'd like to make this the official source of the tracker.
There was a problem hiding this comment.
M == 512, N == 4096, K == 512
M == 4096, N == 512, K == 512
newling
force-pushed
the
add_ukernel_benchmarking
branch
from
d3387a2
to
7805b30
Compare
yzhang93
reviewed
Nov 19, 2024
Yes I'm 90% sure it'll be fixed after rebasing on #911 (windows + ukernel = doesn't work) |
newling
force-pushed
the
add_ukernel_benchmarking
branch
from
7805b30
to
d2c93ea
Compare
newling
changed the title
yzhang93
reviewed
Nov 21, 2024
yzhang93
approved these changes
Nov 21, 2024
jtuyls
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now prints performance numbers for shapes
(M, N, K) = (512, 512, 4096) and (512, 4096, 512) and (4096, 512, 512)
with and without ukernels. Numbers with ukernels are interesting, take a look in CI, different gain with ukernel for the different shapes.
But looks like there's some improvement we can make on the vectorization of matmul front.