Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ObjectFifo] Add pass to flatten the logical objectFifo #638

Merged
merged 3 commits into from
Aug 6, 2024
Merged

[ObjectFifo] Add pass to flatten the logical objectFifo #638

merged 3 commits into from
Aug 6, 2024

Conversation

yzhang93
Copy link
Contributor

@yzhang93 yzhang93 commented Aug 3, 2024 •
edited
Loading

This PR is part to achieve #644

@yzhang93 yzhang93 changed the title [WIP][ObjectFifo] Add pass to flatten the logical objectFifo [ObjectFifo] Add pass to flatten the logical objectFifo Aug 6, 2024
Abhishek-Varma
Abhishek-Varma requested changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@Abhishek-Varma Abhishek-Varma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments.

Could you come up with a smaller lit test?
Essentially the pass is to demo the linearization of the memref involved in logicalobjectfifo.from_memref + logicalobjectfifo.access. So, we should be able to form a smaller lit test.

compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEFlattenLogicalObjectFifo.cpp Outdated Show resolved Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/AMDAIEFlattenLogicalObjectFifo.cpp Outdated Show resolved Hide resolved
Abhishek-Varma
Abhishek-Varma approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@Abhishek-Varma Abhishek-Varma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@yzhang93 yzhang93 enabled auto-merge (squash) August 6, 2024 22:46
@yzhang93 yzhang93 merged commit ab9fabd into nod-ai:main Aug 6, 2024
2 checks passed
@Abhishek-Varma Abhishek-Varma mentioned this pull request Aug 7, 2024
Open
@yzhang93 yzhang93 mentioned this pull request Aug 8, 2024
Merged
yzhang93 added a commit that referenced this pull request Aug 9, 2024
@yzhang93
[ObjectFifo] Modify LowerToAIE pass to take flattened objectfifos (#652)
15fd82e 
This PR is to add `FlattenLogicalObjectFifo` pass
#638 into the pipeline, and
modifies the tests accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhishek-Varma Abhishek-Varma Abhishek-Varma approved these changes

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@nirvedhmeshram nirvedhmeshram Awaiting requested review from nirvedhmeshram nirvedhmeshram is a code owner

@jtuyls jtuyls Awaiting requested review from jtuyls jtuyls is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yzhang93 @Abhishek-Varma