Initial CI [WIP] #104
Initial CI [WIP] #104
Conversation
.github/workflows/test_e2eshark.yml
Outdated
| - name: "Setup Python venv" | ||
| run: python -m venv ${IREE_VENV_DIR} | ||
|
|
||
| - name: Build iree |
There was a problem hiding this comment.
This (and all the other build steps) should be replaced with a pip install. No need to checkout a repo with all the submodules, configure toolchains (CMake, ninja, etc.), and spent CI time rebuilding from source.
There was a problem hiding this comment.
Yeah, it was a mess getting the whole source build into CI. Should be able to just use the pip install.
.github/workflows/test_e2eshark.yml
Outdated
| pip install -r ../torch-mlir/requirements.txt | ||
| pip install -r ../torch-mlir/torchvision-requirements.txt | ||
| pip install ../torch-mlir/torch-mlir-wheel/torch_mlir-0.0.1-cp311-cp311-linux_x86_64.whl | ||
| pip install -r ./e2eshark/requirements.txt | ||
| pip install -f https://openxla.github.io/iree/pip-release-links.html --upgrade -r ../turbine/core/iree-requirements.txt | ||
| pip install -e ../turbine/core[testing] | ||
| pip install -e ../turbine/models |
There was a problem hiding this comment.
Yikes that's a lot of pip installs. We should be able to get that down to a much shorter list... (turbine, iree, local requirements for this repo)
.github/workflows/test_e2eshark.yml
Outdated
| matrix: | ||
| os: [nodai-amdgpu-w7900-x86-64] |
There was a problem hiding this comment.
nit: this is a machine type, not an OS?
There was a problem hiding this comment.
Yeah for space reasons to run all the models, I was thinking we use this machine
.github/workflows/test_e2eshark.yml
Outdated
| on: | ||
| pull_request: |
There was a problem hiding this comment.
I set up the iree_tests CI to only run on PRs affecting that directory. Could do the same here for e2eshark
SHARK-TestSuite/.github/workflows/test_iree.yml
Lines 7 to 13 in 46ab63b
There was a problem hiding this comment.
Nice! Will do that
Signed-off-by: Gaurav Shukla<[email protected]> Co-authored-by: zjgarvey <[email protected]> Co-authored-by: kumardeepakamd <[email protected]> Co-authored-by: Scott Todd <[email protected]> Co-authored-by: zjgarvey <[email protected]> Co-authored-by: Andreas Falkenberg <[email protected]> Co-authored-by: Xida Ren <[email protected]> Co-authored-by: Xida Ren (Cedar) <[email protected]> Co-authored-by: Gaurav Shukla <[email protected]> Co-authored-by: Kumar Deepak <[email protected]> Co-authored-by: afalkenberg1 <[email protected]> Co-authored-by: Phaneesh Barwaria <[email protected]> Co-authored-by: Chi_Liu <[email protected]>
No description provided.