Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split getPlayerInfo into smaller methods #840

Merged
merged 20 commits into from
Dec 12, 2024
Merged

Split getPlayerInfo into smaller methods #840

merged 20 commits into from
Dec 12, 2024

Conversation

Regalijan
Copy link
Member

This would resolve #830

@Regalijan
Add UsernameHistoryEntry type
229a2ad
@Regalijan
Create getUsernameHistory method
529bef5
@Regalijan
Add test for getUsernameHistory
7751898
@Regalijan
Fix getUsernameHistory test
9b98cff
@Regalijan
Add getFollowerCount method
888af60
@Regalijan
Add getFollowingCount
d94edb7
@Regalijan
Add getFriendCount method
2302dd3
@Regalijan
Create getUserInfo method
6898c81
@Regalijan
Add UserInfo type
70dd76c
@Regalijan
Fix formatting
ce4bec4
@Regalijan
Fix method overall
a5076eb
@Regalijan
It is in fact not an args object
ff975cc
@Regalijan
Remove inclusion of jar param in counts methods
bd7b74f
@Regalijan
Replace constructRequest with imports of needed methods
7667746
@Regalijan
Add function types
c9dc824
@Regalijan
Export other created methods
9b909c5
@Regalijan
Actually return the data object instead of whole response (and parse …
e7b3dec 
…date)
@Regalijan
Add test for getUserInfo
b79754b
@Regalijan
Remove stray import
13315e3
@Regalijan
Merge branch 'master' into split-getplayerinfo
ab0ac76
@Regalijan Regalijan requested a review from Neztore December 11, 2024 23:16
@Neztore
Copy link
Member

Neztore commented Dec 12, 2024

I will release a new minor version once this is merged

@Regalijan Regalijan merged commit f4b8801 into noblox:master Dec 12, 2024
2 checks passed
@Regalijan Regalijan deleted the split-getplayerinfo branch December 13, 2024 01:58
@Regalijan Regalijan mentioned this pull request Dec 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neztore Neztore Neztore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Opting out to getPlayerInfo data to reduce ratelimits
2 participants
@Regalijan @Neztore