feat: [PC-13433]: add get Adjustment Events #228
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrkazulak
force-pushed
the
PC-13433-sloctl-new-command-for-getdeleteupdate-of-adjustments
branch
from
34b34be
to
826f51e
Compare
piotrkazulak
changed the title
…ate-of-adjustments
kubaceg
requested changes
Oct 10, 2024
internal/budgetadjustments/flags.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| flagAdjustment = "adjustment-name" |
There was a problem hiding this comment.
maybe just name? we have sloctl budgetadjustments --adjustment-name for me adjustment in flag is uncessary duplication
There was a problem hiding this comment.
We are getting events by adjustment name so lets leave it as it is
kubaceg
requested changes
Oct 10, 2024
## Summary Correct failing new parameters tests
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [cspell](https://cspell.org/) ([source](https://redirect.github.com/streetsidesoftware/cspell/tree/HEAD/packages/cspell)) | [`8.14.4` -> `8.15.1`](https://renovatebot.com/diffs/npm/cspell/8.14.4/8.15.1) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>streetsidesoftware/cspell (cspell)</summary> ### [`v8.15.1`](https://redirect.github.com/streetsidesoftware/cspell/blob/HEAD/packages/cspell/CHANGELOG.md#small8151-2024-10-11-small) [Compare Source](https://redirect.github.com/streetsidesoftware/cspell/compare/v8.15.0...v8.15.1) - fix: Sign Published Packages ([#​6350](https://redirect.github.com/streetsidesoftware/cspell/issues/6350)) ([633b060](https://redirect.github.com/streetsidesoftware/cspell/commit/633b060)), closes [#​6350](https://redirect.github.com/streetsidesoftware/cspell/issues/6350) ### [`v8.15.0`](https://redirect.github.com/streetsidesoftware/cspell/blob/HEAD/packages/cspell/CHANGELOG.md#8150-2024-10-11) [Compare Source](https://redirect.github.com/streetsidesoftware/cspell/compare/v8.14.4...v8.15.0) - chore: bump eslint-plugin-unicorn from 55.0.0 to 56.0.0 ([#​6332](https://redirect.github.com/streetsidesoftware/cspell/issues/6332)) ([67d1e92](https://redirect.github.com/streetsidesoftware/cspell/commit/67d1e92)), closes [#​6332](https://redirect.github.com/streetsidesoftware/cspell/issues/6332) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/nobl9/sloctl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTUuMSIsInVwZGF0ZWRJblZlciI6IjM4LjExNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJqYXZhc2NyaXB0IiwicmVub3ZhdGUiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [yaml](https://eemeli.org/yaml/) ([source](https://redirect.github.com/eemeli/yaml)) | [`2.5.1` -> `2.6.0`](https://renovatebot.com/diffs/npm/yaml/2.5.1/2.6.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>eemeli/yaml (yaml)</summary> ### [`v2.6.0`](https://redirect.github.com/eemeli/yaml/releases/tag/v2.6.0) [Compare Source](https://redirect.github.com/eemeli/yaml/compare/v2.5.1...v2.6.0) - Use a proper tag for `!!merge <<` keys ([#​580](https://redirect.github.com/eemeli/yaml/issues/580)) - Add `stringKeys` parse option ([#​581](https://redirect.github.com/eemeli/yaml/issues/581)) - Stringify a Document as a Document ([#​576](https://redirect.github.com/eemeli/yaml/issues/576)) - Add sponsorship by [Manifest](https://manifest.build/) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/nobl9/sloctl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTUuMSIsInVwZGF0ZWRJblZlciI6IjM4LjExNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiLCJqYXZhc2NyaXB0IiwicmVub3ZhdGUiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…ommand-for-getdeleteupdate-of-adjustments # Conflicts: # package.json
…ate-of-adjustments
…ate-of-adjustments
nieomylnieja
requested changes
Nov 12, 2024
piotrkazulak
force-pushed
the
PC-13433-sloctl-new-command-for-getdeleteupdate-of-adjustments
branch
from
d1add0c
to
ad22a73
Compare
nieomylnieja
requested changes
Nov 13, 2024
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "update", | ||
| Short: "Update existing events with new values. Values for eventStart and eventEnd are required.", |
There was a problem hiding this comment.
Suggested change
| Short: "Update existing events with new values. Values for eventStart and eventEnd are required.", | |
| Short: "Update past existing events with new values. Values for eventStart and eventEnd are required.", |
|
|
||
| cmd := &cobra.Command{ | ||
| Use: "delete", | ||
| Short: "Delete existing events.", |
There was a problem hiding this comment.
Suggested change
| Short: "Delete existing events.", | |
| Short: "Delete past existing events.", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This change is a part of new Error Budget Adjustments management feature. We need to have a way to get/update/delete Events related to an Adjustments.
Summary
Add new command to
sloctltoTesting
See added examples of usage
Release Notes
New Past Adjustment functionality. Allow users to manage past events.