Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/src lines #187

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Refactor/src lines #187

wants to merge 3 commits into from

Conversation

nobiot
Copy link
Owner

@nobiot nobiot commented May 8, 2023

No description provided.

nobiot added 3 commits May 8, 2023 17:01
The basic intent is to refactor -src-lines.el to separate the scope of
src and lines more clearly. The hope is also to make thing-at-point
separate from both.

To do this, the first thing done in this commit is to separate out the
function to wrap the content into src. This is now done by the abnormal
function hook -content-format-functions.

In order to do this, the hook's function call API has been changed. The
last argument of the unction call in the hook used to be
:current-indentation. This is anyway part of the keyword-values plist,
so the function API now expects the plist instead of just
:current-indentation.
@nobiot
Copy link
Owner Author

nobiot commented May 8, 2023

@devcarbon-com
I am trying to refactor src-lines.el. I feel that function org-transclusion-content-range-of-lines is too long and it does :lines and :thing-at-point -- I was hoping to separate them into their own functions.

I have tried this below, but it cannot find the thing boundary correct for defun and sexp. Do you see where I am wrong? sentence and paragraph seem to work OK. I am using test/things-at-point.org as the test.

https://github.com/nobiot/org-transclusion/blob/refactor/src-lines/org-transclusion-src-lines.el#L343-L381

@devcarbon-com
Copy link
Contributor

Hey @nobiot , I'll be happy to take a look, but so you know it will probably be a few weeks before I can.

@nobiot
Copy link
Owner Author

nobiot commented May 12, 2023

Timing is perfect 👍 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants